Review main Merged

63079[FEATURE] Add placeholder processor in Yaml import

Silvia Bigler CR +2 V +2 Hard +403 −58 updated 02/21/20, 18:11

Commit message

Rework placeholder processing to allow custom processors

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1217

  1. Silvia Bigler uploaded patch set 1 01/31/20, 10:37

  2. Benni Mack commented on patch set 1 CR -1 01/31/20, 10:39

    Signals are going to deprecated in TYPO3 v10. We should implement PSR-14 events instead. For this purpose however, I wonder if we should use a different technique - that is building a flexible processor logic so placeholders can be nested etc. Making this similarly powerful as Symfonys Config Loader logic.
  3. TYPO3com voted on patch set 1 V -1 01/31/20, 10:49 Completed build in 11m 55s on Fri, 31 Jan, 10:49 AM Test Summary: 54 of 71327 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40390

  4. Silvia Bigler uploaded patch set 2 02/12/20, 13:52

  5. Silvia Bigler commented on patch set 2 02/12/20, 13:59

    > Patch Set 1: Code-Review-1 > > Signals are going to deprecated in TYPO3 v10. We should implement PSR-14 events instead. > > For this purpose however, I wonder if we should use a different technique - that is building a flexible processor logic so placeholders can be nested etc. Making this similarly powerful as Symfonys Config Loader logic. Based on our chitchat in slack, I've implemented a different approach now. This should be pretty flexible, as placeholders can be nested inline (%env(%another(placeholder)%)%) and also recursively (replacement of a placeholder gets searched for placeholders again). New placeholder processors may be sorted (before and after options), and existing ones disabled. It will certainly work for my needs. Hope for the general needs too.
  6. TYPO3com voted on patch set 2 V +1 02/12/20, 14:07 Completed build in 14m 49s on Wed, 12 Feb, 02:07 PM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14

  7. Anja Leichsenring commented on patch set 2 CR -1 02/13/20, 09:24

    we need a documentation .rst file here that explains the impact and usage of the new feature. Please find further information and help here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html https://forger.typo3.com/utilities/rst
  8. Silvia Bigler uploaded patch set 3 02/13/20, 12:05

  9. Silvia Bigler uploaded patch set 4 02/13/20, 12:11

  10. Silvia Bigler uploaded patch set 5 02/13/20, 12:19

  11. TYPO3com voted on patch set 3 V +1 02/13/20, 12:20 Completed build in 15m 14s on Thu, 13 Feb, 12:20 PM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-46

  12. TYPO3com voted on patch set 4 V +1 02/13/20, 12:26 Completed build in 15m 24s on Thu, 13 Feb, 12:26 PM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-47

  13. TYPO3com voted on patch set 5 V +1 02/13/20, 12:33 Completed build in 13m 50s on Thu, 13 Feb, 12:33 PM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-48

  14. Susi Moog voted on patch set 5 V +1 CR +1 02/21/20, 11:00

  15. Daniel Goerz voted on patch set 5 CR +1 02/21/20, 13:28

  16. Benni Mack voted on patch set 5 V +2 CR +2 02/21/20, 18:11

  17. Benni Mack merged patch set 6 02/21/20, 18:11