63097[TASK] Remove unused functionality of PageLayoutView class
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 812
-
Benni Mack uploaded patch set 1 01/31/20, 13:10
-
TYPO3com voted on patch set 1 V +1 01/31/20, 13:23 Completed build in 12m 46s on Fri, 31 Jan, 01:23 PM Test Summary: 71181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40408
-
Benni Mack uploaded patch set 2 01/31/20, 13:33
-
TYPO3com voted on patch set 2 V +1 01/31/20, 13:48 Completed build in 13m 38s on Fri, 31 Jan, 01:48 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40411
-
Oliver Klee commented on patch set 2 01/31/20, 13:50
PageLayoutView.php:261UnresolvedPlease let's have a type declaraton for the new parameter. -
Benni Mack commented on patch set 2 01/31/20, 15:07
PageLayoutController.php:658Reply UnresolvedIt's actually cleaning up code, as the code produced a closing </form> tag at any time. Now that I look at the code closer, the function checks can be removed, as there is only setting 1 and 2 allowed anyways. -
Benni Mack uploaded patch set 3 01/31/20, 15:09
-
TYPO3com voted on patch set 3 V -1 01/31/20, 15:19 Completed build in 10m 14s on Fri, 31 Jan, 03:19 PM Test Summary: 70887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40423
-
TYPO3com voted on patch set 3 V +1 01/31/20, 15:28 Completed build in 29m 37s on Fri, 31 Jan, 03:28 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40423
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 02/02/20, 07:59
-
Georg Ringer voted on patch set 3 V +2 CR +2 02/03/20, 09:44
-
Georg Ringer merged patch set 4 02/03/20, 09:44
PageLayoutController.php:658