Review main Merged

63098[TASK] Streamline compatibility slots of SignalSlot Dispatcher

Benni Mack CR +2 V +2 Normal +17 −52 updated 01/31/20, 15:24

Commit message

The first PSR-14 event received a custom Compatibility slot.
All further "old" slots have been moved to "SlotReplacement" classes,
which is now done with this first PSR-14 event (AfterMailerInitializationEvent)
as well, and moved to a more generic MailerInterface API, now that symfony/mailer
is stable.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Benni Mack uploaded patch set 1 01/31/20, 13:45

  2. TYPO3com voted on patch set 1 V -1 01/31/20, 13:48 Completed build in 02m 26s on Fri, 31 Jan, 01:48 PM Test Summary: 10035 of 71470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40412

  3. Benni Mack uploaded patch set 2 01/31/20, 14:09

  4. TYPO3com voted on patch set 2 V +1 01/31/20, 14:20 Completed build in 10m 34s on Fri, 31 Jan, 02:20 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40415

  5. Susi Moog voted on patch set 2 CR +1 01/31/20, 14:57

  6. Susi Moog voted on patch set 2 V +1 01/31/20, 15:07

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 01/31/20, 15:24

  8. Daniel Goerz merged patch set 3 01/31/20, 15:24