Review main Merged

63101[TASK] Access VH VariableContainer through RenderingContext

Claus Due CR +2 V +2 Normal +67 −51 updated 02/14/20, 19:52

Commit message

Changes access of $this->viewHelperVariableContainer to
$this->renderingContext->getViewHelperVariableContainer
since the former is deprecated in AbstractViewHelper.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 57

  1. Claus Due uploaded patch set 1 01/31/20, 14:35

  2. TYPO3com voted on patch set 1 V +1 01/31/20, 14:46 Completed build in 10m 07s on Fri, 31 Jan, 02:46 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40420

  3. Claus Due updated the commit message in patch set 2 01/31/20, 19:35

  4. TYPO3com voted on patch set 2 V +1 01/31/20, 19:46 Completed build in 10m 37s on Fri, 31 Jan, 07:46 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40441

  5. Benni Mack voted on patch set 2 V +1 CR +1 01/31/20, 21:34

  6. Georg Ringer voted on patch set 2 V +2 CR +2 02/14/20, 19:52

  7. Georg Ringer merged patch set 3 02/14/20, 19:52