Review main Abandoned

63102[TASK] Don't throw exception for unsupported RenderingContext

Claus Due CR 0 V 0 Easy +1 −8 updated 01/31/20, 15:15

Commit message

Throwing an exception when RenderingContext is of an
unknown type is not required - implementations are
technically compatible. It is enough to avoid calling
particular methods if the instance is of unknown type.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Claus Due uploaded patch set 1 01/31/20, 14:47

  2. TYPO3com voted on patch set 1 V +1 01/31/20, 14:57 Completed build in 10m 36s on Fri, 31 Jan, 02:57 PM Test Summary: 71181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40421

  3. Claus Due abandoned the change 01/31/20, 15:15

    Actually not required - was only necessary because the first iteration of the Fluid 3.0 compatibility patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/63043 used an XCLASS for RenderingContext; this is no longer the case.