Review main Merged

63107[BUGFIX] Rework AJAX request queueing

Andreas Kienast CR +2 V +2 Hard +158 −155 updated 02/14/20, 19:01

Commit message

This patch reworks the queueing system for AJAX requests sent by the
extension scanner. This implementation now really only sends the allowed
amount of concurrent requests and queues the remaining requests.

When the extension scanner gets closed, the queue gets flushed and the
remaining running requests get aborted. Since aborting a request triggers
a DOMException, the rather useless "Oops" notification gets removed.

The extension scanner now also queues requests where it actually makes
sense.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1624

  1. Andreas Kienast uploaded patch set 1 01/31/20, 17:00

  2. Andreas Kienast abandoned the change 01/31/20, 17:02

  3. Andreas Kienast restored the change 01/31/20, 17:03

  4. Andreas Kienast uploaded patch set 2 01/31/20, 17:04

  5. TYPO3com voted on patch set 1 V +1 01/31/20, 17:19 Completed build in 17m 22s on Fri, 31 Jan, 05:19 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40434

  6. TYPO3com voted on patch set 2 V +1 01/31/20, 17:27 Completed build in 21m 33s on Fri, 31 Jan, 05:27 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40436

  7. Benni Mack voted on patch set 2 CR +1 01/31/20, 21:56

  8. Andreas Kienast uploaded patch set 3 02/01/20, 12:55

  9. TYPO3com voted on patch set 3 V +1 02/01/20, 13:09 Completed build in 13m 26s on Sat, 1 Feb, 01:09 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40449

  10. Andreas Kienast uploaded patch set 4 02/01/20, 17:30

  11. TYPO3com voted on patch set 4 V -1 02/01/20, 17:40 Completed build in 10m 07s on Sat, 1 Feb, 05:40 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40457

  12. Andreas Kienast commented on patch set 4 CR -2 02/01/20, 18:58

  13. Andreas Kienast rebased onto patch set 5 02/02/20, 08:05

  14. Andreas Kienast voted on patch set 5 CR 0 02/02/20, 08:05

  15. TYPO3com voted on patch set 5 V -1 02/02/20, 08:15 Completed build in 09m 54s on Sun, 2 Feb, 08:15 AM Test Summary: 70755 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40461

  16. Andreas Kienast rebased onto patch set 6 02/03/20, 10:58

  17. TYPO3com voted on patch set 6 V +1 02/03/20, 11:07 Completed build in 09m 36s on Mon, 3 Feb, 11:07 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40507

  18. Andreas Kienast rebased onto patch set 7 02/12/20, 08:51

  19. TYPO3com voted on patch set 7 V -1 02/12/20, 10:46 Completed build in 16m 08s on Wed, 12 Feb, 10:46 AM Test Summary: 6 of 71712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10

  20. Andreas Kienast rebased onto patch set 8 02/12/20, 12:03

  21. TYPO3com voted on patch set 8 V +1 02/12/20, 12:16 Completed build in 13m 10s on Wed, 12 Feb, 12:16 PM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12

  22. Richard Haeser voted on patch set 8 V +1 CR +1 02/14/20, 13:35

  23. Georg Ringer voted on patch set 8 V +2 CR +2 02/14/20, 19:01

  24. Georg Ringer merged patch set 9 02/14/20, 19:01