Review main Merged

63109[TASK] Use ModuleTemplate in BackendController

Benni Mack CR +2 V +2 Normal +78 −60 updated 02/03/20, 09:44

Commit message

The main entry point for the TYPO3 backend is the BackendController.

Some changes are made:
- Only instantiate necessary code
- Use $uriBuilder as property
- Use ModuleTemplate's view to not instantiate a Fluid view multiple times

This eases the way to lower the usage of DocumentTemplate again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 01/31/20, 17:30

  2. TYPO3com voted on patch set 1 V -1 01/31/20, 17:39 Completed build in 09m 45s on Fri, 31 Jan, 05:39 PM Test Summary: 11 of 71635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40439

  3. Benni Mack uploaded patch set 2 01/31/20, 22:29

  4. TYPO3com voted on patch set 2 V +1 01/31/20, 22:47 Completed build in 18m 35s on Fri, 31 Jan, 10:47 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40447

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/02/20, 08:09

  6. Georg Ringer voted on patch set 2 V +2 CR +2 02/03/20, 09:42

  7. Georg Ringer merged patch set 3 02/03/20, 09:42

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 02/03/20, 09:44

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 02/03/20, 09:44