Review main Merged

63110[TASK] Avoid Fluid JS escaping trick in new content wizard

Claus Due CR +2 V +2 Easy +2 −2 updated 02/09/20, 10:17

Commit message

Assigns the entire goToalt_doc JS method from the new
content wizard controller, which prevents the need for
using a JS escaping trick in Fluid.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Claus Due uploaded patch set 1 01/31/20, 19:40

  2. TYPO3com voted on patch set 1 V -1 01/31/20, 19:52 Completed build in 11m 40s on Fri, 31 Jan, 07:52 PM Test Summary: 70675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40442

  3. TYPO3com voted on patch set 1 V +1 01/31/20, 20:17 Completed build in 48m 38s on Fri, 31 Jan, 08:17 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40442

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/31/20, 21:52

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 02/03/20, 20:25

  6. Daniel Goerz merged patch set 2 02/03/20, 20:25

  7. Daniel Goerz commented on patch set 2 02/03/20, 20:41

    Hey Claus, could you take care of the backport to v8? I cant find it there right now.
  8. Claus Due commented on patch set 2 02/09/20, 10:17

    @Daniel I actually made a mistake with the backport version tags here: the patch isn't required on 8.7 since it attaches the JS from PHP via the ModuleTemplate class. Sorry about the confusion, I made at least 5 other patches that day which all apply to 8.7 and missed the fact that this one doesn't.