Review 9.5 Merged

63116[BUGFIX] Improve visual output of slug proposal

Benni Mack CR +2 V +2 Easy +4 −3 updated 02/03/20, 11:31

Commit message

If slugs are generated within Backend forms, the visual output (= label
below slug field) of the generated slug proposal might be broken if no
slash is prepended to the generated slug. This might be the case in custom
database tables where custom slug fields are defined with the
configuration "prependSlash" set to "false" (which is the default value).
It can also be the case if the configuration "prefixParentPageSlug" is set
to "false".

In order to ensure a clean visual output for those labels, the slug
proposalwithin them will now always be prepended by a slash. This makes
sure that the resulting url which is shown within those labels is always
valid. Note that this only effects visual output and is not meant to
modify any slug proposal generated by the SlugHelper class.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Elias Häußler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack commented on patch set 1 02/03/20, 09:35

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SlugElement.ts * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SlugElement.js
  2. TYPO3com voted on patch set 1 V -1 02/03/20, 09:46 Completed build in 10m 56s on Mon, 3 Feb, 09:46 AM Test Summary: 73971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1954

  3. TYPO3com commented on patch set 1 02/03/20, 09:59 Completed build in 11m 38s on Mon, 3 Feb, 09:59 AM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1955

  4. Elias Häußler uploaded patch set 2 02/03/20, 09:59

  5. TYPO3com voted on patch set 2 V +1 02/03/20, 10:11 Completed build in 11m 26s on Mon, 3 Feb, 10:11 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1956

  6. Elias Häußler commented on patch set 2 V +1 CR +1 02/03/20, 10:14

    Resolved conflicts; this is now ready for review.
  7. Benni Mack commented on patch set 2 02/03/20, 11:30

    This change is ready for review.
  8. Benni Mack voted on patch set 2 V +2 CR +2 02/03/20, 11:30

  9. Benni Mack merged patch set 3 02/03/20, 11:31