Review main Merged

63132[TASK] Allow typo3fluid/fluid:^3 in composer manifests

Claus Due CR +2 V +2 Normal +42 −11 updated 03/23/20, 20:01

Commit message

Pure metadata change - allows site admin to create a new
site which uses Fluid 3.0.

A separate change will come in TYPO3 v9.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 3043

Show 1118 earlier messages
  1. Claus Due uploaded patch set 1 01/31/20, 19:50

  2. TYPO3com voted on patch set 1 V -1 01/31/20, 20:01 Completed build in 10m 01s on Fri, 31 Jan, 08:01 PM Test Summary: 70878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40444

  3. TYPO3com commented on patch set 1 01/31/20, 20:15 Completed build in 34m 38s on Fri, 31 Jan, 08:15 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40444

  4. Claus Due uploaded patch set 2 02/01/20, 13:08

  5. TYPO3com voted on patch set 2 V -1 02/01/20, 13:08 Completed build in 12s on Sat, 1 Feb, 01:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40450

  6. Claus Due uploaded patch set 3 02/01/20, 13:09

  7. TYPO3com voted on patch set 3 V -1 02/01/20, 13:09 Completed build in 13s on Sat, 1 Feb, 01:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40451

  8. Claus Due uploaded patch set 4 02/01/20, 13:25

  9. TYPO3com voted on patch set 4 V +1 02/01/20, 13:37 Completed build in 12m 16s on Sat, 1 Feb, 01:37 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40452

  10. Anja Leichsenring commented on patch set 4 02/02/20, 08:28

    has the version already been tagged? By trying `composer require typo3fluid/fluid:^3` I get The requested package typo3fluid/fluid ^3 is satisfiable by typo3fluid/fluid[3.0.x-dev] but these conflict with your requirements or minimum-stability. Also, we will need a change for the typo3/testing-framework to allow fluid 3.0.
  11. Claus Due commented on patch set 4 02/02/20, 10:58

    > The requested package typo3fluid/fluid ^3 is satisfiable by typo3fluid/fluid[3.0.x-dev] but these conflict with your requirements or minimum-stability. It's currently only possible to install if you set "minimum-stability": "dev" in composer.json - I'm coordinating with Benni about when to tag the "real" 3.0, there's still one TODO I have to take care of.
  12. Claus Due commented on patch set 4 02/02/20, 11:12

    By the way: there are four other patches that would have to be merged for Fluid 3.0 to actually work; the four "TASK" patches you see in the list of same-topic patches currently: * Check methods in RenderingContext * Add base widget class methods * Avoid Fluid JS escaping trick (this one is only to makes the "new content" wizard work) * Access VH VariableContainer through RenderingContext Each of those patches solve individual incompatibilities with Fluid 3.0. The two most important ones are "Check methods in RenderingContext" and "Access VH VariableContainer through RenderingContext" - with those applied, everything except for Widgets and the new content wizard should be working.
  13. Georg Ringer voted on patch set 4 V +1 CR +1 02/15/20, 08:32

  14. Georg Ringer voted on patch set 4 V +2 CR +2 02/15/20, 08:32

  15. Claus Due uploaded patch set 5 02/15/20, 10:03

  16. Claus Due uploaded patch set 6 02/15/20, 10:08

  17. TYPO3com voted on patch set 6 V -1 02/15/20, 10:13 Completed build in 25s on Sat, 15 Feb, 10:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-104

  18. TYPO3com voted on patch set 5 V +1 02/15/20, 10:22 Completed build in 17m 23s on Sat, 15 Feb, 10:22 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-103

  1. Claus Due uploaded patch set 7 02/15/20, 19:32

  2. TYPO3com voted on patch set 7 V -1 02/15/20, 19:32 Completed build in 20s on Sat, 15 Feb, 07:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-139

  3. Claus Due uploaded patch set 8 02/15/20, 19:43

  4. TYPO3com voted on patch set 8 V +1 02/15/20, 20:06 Completed build in 15m 41s on Sat, 15 Feb, 08:06 PM Test Summary: 71293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-144

  5. Georg Ringer voted on patch set 8 V +1 CR +1 02/16/20, 16:26

  6. Christian Eßl voted on patch set 8 V +1 CR +1 02/16/20, 17:00

  7. Benni Mack commented on patch set 8 02/16/20, 23:48

    This would mean that everyone with a composer-based installation would get Fluid 3.0 as soon it's released. I feel this should be considered either Important or Breaking or something along the lines - in case third-party things would break? Otherwise, I'd go with "master-only" in this case.
  8. Claus Due commented on patch set 8 02/16/20, 23:54

    @Benni my reasoning is that third party packages which depend on Fluid would mark that they depend on `typo3fluid/fluid:^2` and as such, wouldn't get Fluid 3.0 until they are ready for it. This may be a bit of an assumption but it would be "bad practice" to not declare the dependency with an upper constraint, or not declare it at all? In any case I'd certainly prefer we don't go "master only" since that would mean Fluid 3.0 can not be used with 9.5 and 8.7 as planned. Is there another way, like a feature flag we could use, or can we prefer a certan version in composer yet still allow another (but only if user requires ^3 for example)?
  9. Claus Due commented on patch set 8 02/16/20, 23:56

    > Is there another way, like a feature flag we could use, or can we prefer a certan version in composer yet still allow another (but only if user requires ^3 for example)? Perhaps we could accept that users who don't want 3.0 can do `composer require typo3fluid/fluid:^2` in their project to downgrade? After all this only affects composer installs so a downgrade would be easy to do... Let me know if I should add an important-RST, I can take care of that tomorrow morning.
  10. Claus Due uploaded patch set 9 02/17/20, 20:43

  11. Claus Due commented on patch set 9 02/17/20, 20:48

    I added an "important-dot-RST" to describe the potential version conflict, which types of projects might be affected and what to do to avoid it. Hope that's good enough?
  12. TYPO3com voted on patch set 9 V +1 02/17/20, 21:01 Completed build in 17m 44s on Mon, 17 Feb, 09:01 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-223

  13. Benni Mack commented on patch set 9 02/19/20, 23:06

    > Patch Set 8: > > @Benni my reasoning is that third party packages which depend on Fluid would mark that they depend on `typo3fluid/fluid:^2` and as such, wouldn't get Fluid 3.0 until they are ready for it. This may be a bit of an assumption but it would be "bad practice" to not declare the dependency with an upper constraint, or not declare it at all? > > In any case I'd certainly prefer we don't go "master only" since that would mean Fluid 3.0 can not be used with 9.5 and 8.7 as planned. > > Is there another way, like a feature flag we could use, or can we prefer a certan version in composer yet still allow another (but only if user requires ^3 for example)? You know, this is how we do it in our company - if we with TYPO3 v8/v9 would want to use fluidtypo3 we would do "composer req "fluidtypo3/fluid:^3 as 2.6.9" and explicitly use it. This way it is safer IMHO. We could also add the major support later in v9/v8 once we've seen it in the wild (basically doing this change for master only and then apply the same process for a v9/v8 targetted change later-on). What do you think?
  14. Claus Due commented on patch set 9 02/20/20, 08:59

    > You know, this is how we do it in our company - if we with TYPO3 v8/v9 would want to use fluidtypo3 we would do "composer req "fluidtypo3/fluid:^3 as 2.6.9" and explicitly use it. This way it is safer IMHO. I know, but this way has some drawbacks - the use of Fluid 3.0 in that case is not formalised, no packages can depend on it or exclude it. It is fine for single projects but prevent the distribution of packages that require Fluid 3.0. > We could also add the major support later in v9/v8 once we've seen it in the wild (basically doing this change for master only and then apply the same process for a v9/v8 targetted change later-on). What do you think? I like this approach more. I suggest this plan then: * Merge for master before release of 10.3 * New installs of 10.3 then get Fluid 3.0 unless project or dependencies strictly depend on ^2 * About a month after 10 LTS is released we can backport to 9.5/8.7 This would also give extension authors some time to make sure their extensions work with 3.0, or restrict their dependencies to disallow 3.0. ...but we still need to have https://review.typo3.org/c/Packages/TYPO3.CMS/+/63111 merged first, otherwise master would break with 3.0.
  15. Claus Due uploaded patch set 10 02/20/20, 10:24

  16. TYPO3com voted on patch set 10 V -1 02/20/20, 10:37 Completed build in 24s on Thu, 20 Feb, 10:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-337

  17. Claus Due uploaded patch set 11 02/20/20, 10:38

  18. TYPO3com voted on patch set 11 V +1 02/20/20, 10:58 Completed build in 19m 25s on Thu, 20 Feb, 10:58 AM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-338

  19. Claus Due commented on patch set 11 02/21/20, 17:08

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/63111 is merged, now we can come around to this one - I'm 100% on board with your plan to do master first, wait a long time and *then* do 9.5/8.7, Benni.
  20. Benni Mack commented on patch set 11 03/23/20, 14:53

    OK. Should I proceed?
  21. Claus Due commented on patch set 11 03/23/20, 15:01

    > Patch Set 11: > > OK. Should I proceed? Maybe we should add a note in the RST that Fluid 3.x is not yet released and that an official notice will follow (on typo3.org news?) when that happens. Until that time, only composer installs which have "minimum-stability: dev" will be able to install it. I can take a look at this later today if you don't beat me to it. I still need much more testing feedback from others before I feel confident enough to tag version 3.0 - and allowing it in composer should help with that. Should we come across any major issues that aren't possible to solve in time for v10 LTS we can always revert and restore the constraint!
  22. Benni Mack uploaded patch set 12 03/23/20, 19:48

  23. TYPO3com voted on patch set 12 V +1 03/23/20, 20:01 Completed build in 12m 27s on Mon, 23 Mar, 08:01 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1641

  24. Benni Mack voted on patch set 12 V +2 CR +2 03/23/20, 20:01

  25. Benni Mack merged patch set 13 03/23/20, 20:01