Review 9.5 Merged

63135[BUGFIX] Rework AJAX request queueing

Andreas Kienast CR +2 V +2 Hard +188 −181 updated 02/14/20, 20:56

Commit message

This patch reworks the queueing system for AJAX requests sent by the
extension scanner. This implementation now really only sends the allowed
amount of concurrent requests and queues the remaining requests.

When the extension scanner gets closed, the queue gets flushed and the
remaining running requests get aborted. Since aborting a request triggers
a DOMException, the rather useless "Oops" notification gets removed.

The extension scanner now also queues requests where it actually makes
sense.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 47

  1. Andreas Kienast uploaded patch set 1 02/01/20, 12:53

  2. TYPO3com voted on patch set 1 V +1 02/01/20, 13:03 Completed build in 10m 40s on Sat, 1 Feb, 01:03 PM Test Summary: 74265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1939

  3. Andreas Kienast rebased onto patch set 2 02/12/20, 10:26

  4. TYPO3com voted on patch set 2 V -1 02/12/20, 10:38 Completed build in 11m 33s on Wed, 12 Feb, 10:38 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-6

  5. TYPO3com voted on patch set 2 V +1 02/12/20, 10:41 Completed build in 26m 12s on Wed, 12 Feb, 10:41 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-6

  6. Georg Ringer voted on patch set 2 V +2 CR +2 02/14/20, 20:56

  7. Georg Ringer merged patch set 3 02/14/20, 20:56