Review TYPO3_8-7 Merged

63136[TASK] Make ViewHelpers compatible with Fluid 3.x

Claus Due CR +2 V +2 Normal +61 −11 updated 03/04/20, 08:05

Commit message

This change adds a handful of conditions and duplicates some
code in order to achieve compatibility with Fluid 3.0. See
issue description for further details:

https://forge.typo3.org/issues/90289

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 915

  1. Claus Due uploaded patch set 1 02/01/20, 13:05

  2. TYPO3com voted on patch set 1 V -1 02/01/20, 13:05 Completed build in 13s on Sat, 1 Feb, 01:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3844

  3. Claus Due uploaded patch set 2 02/01/20, 13:20

  4. TYPO3com voted on patch set 2 V -1 02/01/20, 13:21 Completed build in 16s on Sat, 1 Feb, 01:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3845

  5. Claus Due uploaded patch set 3 02/01/20, 13:22

  6. TYPO3com voted on patch set 3 V -1 02/01/20, 13:32 Completed build in 09m 18s on Sat, 1 Feb, 01:32 PM Test Summary: 40 of 102307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3846

  7. Claus Due uploaded patch set 4 02/01/20, 16:14

  8. TYPO3com voted on patch set 4 V +1 02/01/20, 16:25 Completed build in 10m 59s on Sat, 1 Feb, 04:25 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3847

  9. Claus Due uploaded patch set 5 02/01/20, 16:52

  10. TYPO3com voted on patch set 5 V -1 02/01/20, 16:52 Completed build in 15s on Sat, 1 Feb, 04:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3848

  11. Claus Due uploaded patch set 6 02/01/20, 16:54

  12. TYPO3com voted on patch set 6 V +1 02/01/20, 17:04 Completed build in 09m 19s on Sat, 1 Feb, 05:04 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3849

  13. Georg Ringer voted on patch set 6 CR +1 02/15/20, 08:31

  14. Georg Ringer voted on patch set 6 V +2 CR +2 03/04/20, 08:05

  15. Georg Ringer merged patch set 7 03/04/20, 08:05