Review 9.5 Merged

63138[BUGFIX] Raise symfony/routing to ^4.3 in composer.json

Oliver Hader CR +2 V +2 Easy +3 −3 updated 02/01/20, 18:01

Commit message

To avoid failing nightly tests minimum version of symfony/routing
needs to be 4.3.0 (locked to 4.3.1 in composer.lock currently).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Oliver Hader uploaded patch set 1 02/01/20, 13:33

  2. Andreas Kienast updated the commit message in patch set 2 02/01/20, 13:36

  3. Andreas Kienast voted on patch set 2 CR +1 02/01/20, 13:36

  4. Andreas Kienast commented on patch set 2 CR -1 02/01/20, 13:40

    core/composer.json needs to be fixed as well
  5. Andreas Kienast uploaded patch set 3 02/01/20, 13:42

  6. TYPO3com voted on patch set 1 V -1 02/01/20, 13:44 Completed build in 11m 18s on Sat, 1 Feb, 01:44 PM Test Summary: 73914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1941

  7. TYPO3com voted on patch set 2 V -1 02/01/20, 13:50 Completed build in 13m 17s on Sat, 1 Feb, 01:50 PM Test Summary: 74265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1943

  8. TYPO3com voted on patch set 3 V -1 02/01/20, 13:53 Completed build in 11m 01s on Sat, 1 Feb, 01:53 PM Test Summary: 73463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1944

  9. TYPO3com voted on patch set 3 V +1 02/01/20, 14:01 Completed build in 30m 26s on Sat, 1 Feb, 02:01 PM Test Summary: 74265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1944

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 02/01/20, 15:05

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 02/01/20, 18:01

  12. Andreas Kienast merged patch set 4 02/01/20, 18:01