63139[FEATURE] Dashboard for TYPO3
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Riny van Tiggelen +1
- Benjamin Kott +1
- Björn Jacob +1
- Koen Wouters +1
-
Verified V +2 Done
- Georg Ringer +2
- Riny van Tiggelen +1
- Benjamin Kott +1
- Björn Jacob +1
- Koen Wouters +1
- TYPO3com +1 CI
Issues 1
Files 103
- Build/Sources/Sass/dashboard/_button.scssnew+33 −0
- Build/Sources/Sass/dashboard/_empty.scssnew+29 −0
- Build/Sources/Sass/dashboard/_grid.scssnew+99 −0
- Build/Sources/Sass/dashboard/_header.scss2new+70 −0
- Build/Sources/Sass/dashboard/_module.scssnew+11 −0
- Build/Sources/Sass/dashboard/_widget.scssnew+123 −0
- Build/Sources/Sass/dashboard/_widget_cta.scssnew+26 −0
- Build/Sources/Sass/dashboard/_widget_doughnut_chart.scssnew+13 −0
- Build/Sources/Sass/dashboard/_widget_number.scssnew+27 −0
- Build/Sources/Sass/dashboard/_widget_table.scssnew+71 −0
- Build/Sources/Sass/dashboard_modal/_modal.scss2new+56 −0
- Build/Sources/Sass/variables/_dashboard.scssnew+58 −0
- Build/Sources/Sass/dashboard.scss3new+16 −0
- Build/Sources/Sass/dashboard_modal.scssnew+3 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/DashboardDelete.tsnew+62 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/DashboardModal.tsnew+74 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/Grid.ts7new+92 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetContentCollector.ts3new+58 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetRemover.tsnew+62 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetSelector.tsnew+52 −0
Show 83 more files
- Build/Gruntfile.js+28 −1
- Build/package.json+3 −1
- Build/tsconfig.json+4 −0
- Build/yarn.lock2+10 −0
- typo3/sysext/about/Resources/Private/Partials/ExternalLibraries.html+4 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+6 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-90333-Dashboard.rstnew+157 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+3 −0
- typo3/sysext/core/ext_tables.sql+1 −0
- typo3/sysext/dashboard/Classes/Controller/AbstractController.php8new+44 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php12new+483 −0
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php4new+102 −0
- typo3/sysext/dashboard/Classes/DependencyInjection/DashboardWidgetPass.php1new+69 −0
- typo3/sysext/dashboard/Classes/Exception/NoDashboardAvailableException.phpnew+26 −0
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/AdditionalCssInterface.phpnew+18 −0
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/AdditionalJavaScriptInterface.phpnew+18 −0
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/EventDataInterface.phpnew+17 −0
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/RequireJsModuleInterface.phpnew+21 −0
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/WidgetInterface.php2new+57 −0
- typo3/sysext/dashboard/Classes/Widgets/AbstractCtaButtonWidget.phpnew+44 −0
- typo3/sysext/dashboard/Classes/Widgets/AbstractListWidget.phpnew+43 −0
- typo3/sysext/dashboard/Classes/Widgets/AbstractRssWidget.php11new+76 −0
- typo3/sysext/dashboard/Classes/Widgets/AbstractWidget.php2new+140 −0
- typo3/sysext/dashboard/Classes/Widgets/DocumentationGettingStartedWidget.phpnew+30 −0
- typo3/sysext/dashboard/Classes/Widgets/T3GeneralInformation.php3new+44 −0
- typo3/sysext/dashboard/Classes/Widgets/T3NewsWidget.phpnew+31 −0
- typo3/sysext/dashboard/Classes/Dashboard.phpnew+126 −0
- typo3/sysext/dashboard/Classes/DashboardPreset.phpnew+122 −0
- typo3/sysext/dashboard/Classes/DashboardPresetRegistry.phpnew+57 −0
- typo3/sysext/dashboard/Classes/DashboardRepository.phpnew+219 −0
- typo3/sysext/dashboard/Classes/ServiceProvider.phpnew+237 −0
- typo3/sysext/dashboard/Classes/WidgetGroup.phpnew+61 −0
- typo3/sysext/dashboard/Classes/WidgetGroupRegistry.phpnew+36 −0
- typo3/sysext/dashboard/Classes/WidgetRegistry.phpnew+95 −0
- typo3/sysext/dashboard/Configuration/Backend/AjaxRoutes.phpnew+13 −0
- typo3/sysext/dashboard/Configuration/Backend/DashboardPresets.phpnew+17 −0
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgetGroups.phpnew+9 −0
- typo3/sysext/dashboard/Configuration/Backend/Routes.phpnew+7 −0
- typo3/sysext/dashboard/Configuration/TCA/Overrides/be_groups.phpnew+25 −0
- typo3/sysext/dashboard/Configuration/TCA/be_dashboards.phpnew+103 −0
- typo3/sysext/dashboard/Configuration/Services.phpnew+10 −0
- typo3/sysext/dashboard/Configuration/Services.yaml7new+38 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf3new+130 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang_mod.xlf2new+17 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang_tca.xlfnew+20 −0
- typo3/sysext/dashboard/Resources/Private/Layouts/Widget/Widget.htmlnew+9 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html9new+170 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/CtaWidget.htmlnew+22 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ListWidget.htmlnew+11 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/RssWidget.html4new+29 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/T3GeneralInformation.htmlnew+24 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/TextWidget.htmlnew+8 −0
- typo3/sysext/dashboard/Resources/Public/Css/Modal/style.cssnew+13 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.cssnew+13 −0
- typo3/sysext/dashboard/Resources/Public/Icons/dashboard-cta.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/dashboard-default.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/dashboard-documentation.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/dashboard-empty.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/dashboard-typo3.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/dashboard/Resources/Public/Icons/mimetypes-x-be_dashboard.svgnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/muuri.jsnew+17 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/web-animations.min.jsnew+16 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/web-animations.min.js.mapnew+1 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/DashboardDelete.jsnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/DashboardModal.jsnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/Grid.jsnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetContentCollector.jsnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetRemover.jsnew+13 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetSelector.jsnew+13 −0
- typo3/sysext/dashboard/Tests/Unit/DashboardPresetRegistryTest.phpnew+98 −0
- typo3/sysext/dashboard/Tests/Unit/WidgetGroupRegistryTest.phpnew+115 −0
- typo3/sysext/dashboard/Tests/Unit/WidgetRegistryTest.phpnew+213 −0
- typo3/sysext/dashboard/.gitattributes2new+2 −0
- typo3/sysext/dashboard/composer.jsonnew+47 −0
- typo3/sysext/dashboard/ext_emconf.phpnew+19 −0
- typo3/sysext/dashboard/ext_localconf.php7new+43 −0
- typo3/sysext/dashboard/ext_tables.php4new+24 −0
- typo3/sysext/dashboard/ext_tables.sql2new+9 −0
- typo3/sysext/dashboard/LICENSE.txtnew+345 −0
- composer.json+3 −0
- composer.lock+1 −1
Review log 154194
Show 131169 earlier messages
-
Richard Haeser uploaded patch set 1 02/01/20, 15:00
-
TYPO3com voted on patch set 1 V -1 02/01/20, 15:00 Completed build in 14s on Sat, 1 Feb, 03:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40453
-
Richard Haeser updated the commit message in patch set 2 02/01/20, 15:04
-
TYPO3com voted on patch set 2 V -1 02/01/20, 15:05 Completed build in 17s on Sat, 1 Feb, 03:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40454
-
Claus Due commented on patch set 2 02/01/20, 16:06
Just a quick first look through mainly PHP/Fluid code. Generally: consider adding classes to hold configuration and validation thereof, instead of using associative arrays and validation methods spread throughout various code places..gitattributes:1This file should probably be removed?AbstractController.php:49This should be converted to a multiline constructor call for clarity.AbstractController.php:72Is this method truly inherited - it looks like it would only be called from a single controller associated with saving.DashboardController.php:81UnresolvedCan we reduce the number of constructor arguments here? In relation, if the two repositories are dropped in favor of WidgetGroup and Widget demanding a string name as constructor argument, this would reduce the number of arguments to a more sensible value. Should also be converted to multiline constructor.DashboardController.php:83UnresolvedThe constructor of this class does not appear to match the constructor of the parent class.DashboardController.php:256UnresolvedConsider not hardcoding this, to allow third parties to extend the templates.DashboardController.php:282This line should be formatted correctly with line breaks.DashboardController.php:309UnresolvedDashboardRepository should probably return this identifier-keyed array; then this method can be dropped in favor of calling the dashboard repository directly.DashboardController.php:375UnresolvedConsider refactoring so that $widgetInstance->getJsFiles will produce a numeric array of JS files; same for getCssFiles. Then this method and the method below can be dropped.Dashboard.php:40UnresolvedThis should be initialized as an empty array, since the data type of this property does not match the getter method. Constructor doesn't allow null, so initializing this means the property isn't nullable.Dashboard.php:87This is probably not sensible. Either there should be no $this->widgets property, or the expression here should be: return $this->widgets ?? ($this->widgets = $this->resolveWidgets()); I would consider dropping the internal property.Dashboard.php:96UnresolvedShouldn't this method return Widget instances instead of an array of arrays which contain the instance, that way identifier, title and configuration would be accessible on Widget instead of using associative arrays, which in turn allows code completion.DashboardTemplate.php:50Should be initialized with default value so signature of the property matches the signature of the getter.DashboardTemplate.php:55Should be initialized with default value so signature of the property matches the signature of the getter.DashboardTemplate.php:57It might be better to add a "WidgetConfiguration" class to act as DTO, to get rid of 1) the need to create an array of options and 2) the validation of these options (validation can be done in WidgetConfiguration class).DashboardTemplate.php:123UnresolvedTypo, "should be create" -> "should be created".DashboardTemplatesRepository.php:29UnresolvedGiven that the Dashboard class constructor is fairly light-weight, and dashboards are not expected to be loaded twice, we could avoid this first-level cache. That would reduce this class to a single method, which in turn would make it redundant. Suggested alternative: allow the constructor of Dashboard to accept the string dashboard name and resolve the configuration from there (alternatively, restrict the Dashboard constructor to only accecpt a string dashboard name, which would mean it is required to actually register a dashboard before it can be used - removing the possibility to create a Dashboard instance with arbitrary configuration in an array).AbstractRssWidget.php:18Consider not shipping any RSS-opinionated Widgets. This would mean we avoid the base class, the single implementation and the special template.AbstractWidget.php:121This can be reduced to a single line: $this->view->getRenderingContext()->getTemplatePaths()->fillDefaultsByPackageName($this->extensionKey); Then the condition can also be dropped. Calling fillDefaultsByPackageName twice makes Fluid ignore the first set of paths.WidgetGroup.php:32UnresolvedThe constructor here should require explicit parameters instead of an array which requires associative configuration properties. That removes any confusion about what $config must actually contain, and the "isValidConfig" method can be deleted.WidgetGroupRepository.php:29UnresolvedSee other comment about 1) first level cache perhaps not being necessary and 2) changing constructor of WidgetGroup to require string name of group, then do config resolving from there.RssWidget.html:10This can be compacted to a single f:format.date(format: 'd-m-Y H:m'). Additionally, the date format should be resolved from context instead of hardcoded (the format can be confusing to US/EU users who invert the order of day and month).ext_tables.php:7As mentioned earlier, I would very much prefer if this module was not registered as "top". Let's find another way to set the default for users who haven't configured a default module, to preserve the "Web" category modules order. -
Richard Haeser uploaded patch set 3 02/02/20, 14:56
-
TYPO3com voted on patch set 3 V -1 02/02/20, 14:57 Completed build in 14s on Sun, 2 Feb, 02:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40481
-
Richard Haeser commented on patch set 3 02/02/20, 14:58
.gitattributes:1ReplyDoneAbstractController.php:49ReplyDoneAbstractController.php:72ReplyDoneDashboardController.php:282ReplyDoneDashboard.php:87ReplyDoneDashboardTemplate.php:50ReplyDoneDashboardTemplate.php:55ReplyDoneDashboardTemplate.php:57ReplyAckAbstractRssWidget.php:18ReplyWhat exactly do you mean?AbstractWidget.php:121ReplyDoneRssWidget.html:10ReplyWould you think relying on $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'] is a good idea? Or use the %x and %X options of strftime?ext_tables.php:7ReplyMe too. I already have an idea. Just forgot to mention that this is still in progress -
Richard Haeser wrote 02/03/20, 20:22
Description "Edit commit message" removed -
Richard Haeser uploaded patch set 4 02/03/20, 20:25
-
TYPO3com voted on patch set 4 V -1 02/03/20, 20:25 Completed build in 14s on Mon, 3 Feb, 08:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40537
-
Richard Haeser uploaded patch set 5 02/03/20, 20:44
-
TYPO3com voted on patch set 5 V -1 02/03/20, 20:49 Completed build in 31s on Mon, 3 Feb, 08:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40539
-
Richard Haeser uploaded patch set 6 02/03/20, 21:28
-
TYPO3com voted on patch set 6 V -1 02/03/20, 21:28 Completed build in 15s on Mon, 3 Feb, 09:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40540
-
Richard Haeser uploaded patch set 7 02/04/20, 07:54
-
Richard Haeser uploaded patch set 8 02/04/20, 20:30
-
Richard Haeser rebased onto patch set 9 02/04/20, 20:32
-
Richard Haeser uploaded patch set 10 02/04/20, 20:48
-
Richard Haeser uploaded patch set 11 02/04/20, 23:18
-
Richard Haeser uploaded patch set 12 02/04/20, 23:21
-
Richard Haeser uploaded patch set 13 02/05/20, 19:47
-
Richard Haeser uploaded patch set 14 02/05/20, 21:59
-
Richard Haeser uploaded patch set 15 02/05/20, 22:13
-
Richard Haeser uploaded patch set 16 02/06/20, 17:53
-
Richard Haeser uploaded patch set 17 02/06/20, 19:27
-
Richard Haeser uploaded patch set 18 02/06/20, 20:03
-
Richard Haeser uploaded patch set 19 02/07/20, 12:31
-
Richard Haeser uploaded patch set 20 02/07/20, 14:22
-
Richard Haeser uploaded patch set 21 02/08/20, 19:33
-
Richard Haeser uploaded patch set 22 02/08/20, 21:39
-
Richard Haeser uploaded patch set 23 02/08/20, 22:47
-
Richard Haeser uploaded patch set 24 02/08/20, 23:05
-
Richard Haeser commented on patch set 24 02/08/20, 23:05
This change is ready for review. -
Daniel Siepmann commented on patch set 24 02/09/20, 08:17
Grid.ts:29Right now I'm not able to place two widgets configured with width 4 beside (in my resolution). Once I hide the module bar, I can place them side by side. And even if I add the module sidebar, they stay side by side. Looks like there is some small bug that moving widgets considers a different space then just displaying widgets.WidgetContentCollector.ts:35Right now there is no handling in case the response is an error, e.g. 500 server issue? I guess we should handle that one and display an error message, instead of an endless loader animation.T3GeneralInformation.php:33I guess we need to use lowerCamelCase for variables? So `$typo3Information` and `$typo3Version` should be used. -
Claus Due commented on patch set 24 02/09/20, 10:13
DashboardTemplate.php:20Thinking about this name, I'd chose a different suffix than "Template" since this confuses it with the concept of "Templates" that we currently have in two other contexts: * TypoScript * Fluid Perhaps "DashboardPrototype", "DashboardType", "DashboardPreset" or other could be chosen? To me this class seems more like a "preset" than a "template".AbstractRssWidget.php:18ReplyI mean the RSS feature of the dashboard is highly opinionated (enforces cache, demands simplexml, and exists only because a single shipped Widget uses it). There's a significant amount of code in the extension that's dedicated to this, but parsing and displaying RSS is quite easy to achieve with a custom implementation (of AbstractListWidget). The current implementation requires: * An additional cache definition * An abstract class * An additional Fluid template * An additional CSS asset file * Additional XLF labels * The simplexml PHP extension Seems like a lot of extra code to carry around to facilitate a single widget. The typo3.org news RSS widget also constitutes a "phone home" type of request that makes it possible to track any installation that uses it. Generally I think we should be conservative about adding features that make external requests, which is why I would prefer if the extension didn't provide any such widgets by default. This could also be placed in an optional community extension - afaics there is no "hard" reason why RSS capability has to be included in the dashboard extension itself.RssWidget.html:10ReplyThe "ddmmyy" setting is already an established default and is used, among other things, by the date formatting ViewHelper shipped with the core - if you simply omit the format, then this setting gets used.ext_tables.php:7ReplyCan you give a couple of hints about what your idea is? I'm interested to see how you might solve this. It might also make sense as a separate patch! -
Claus Due commented on patch set 24 02/09/20, 10:33
Getting error: (1/1) #1351584844 TYPO3Fluid\Fluid\Core\ViewHelper\Exception An argument "key" or "id" has to be provided When attempting to load the dashboards view w/o any existing configuration. There are many occurrences of f:translate, e.g. "<f:translate key="{dashboard.title}" default="{dashboard.title}"/>" which use dynamic input variables for "key". Such occurrences must be enclosed with a condition checking that the variable actually exists before it is passed to the template - especially since this error feedback is ambiguous as message for a developer who makes a mistake. -
Claus Due commented on patch set 24 02/09/20, 10:43
Main.html:161As per my last comment: this is the exact occurrence that throws the "no key" error from f:translate. It definitely needs a condition since {currentDashboard} isn't set if you have no dashboards configured (blank state). Also, the '{var}' notation is redundant, you can use simply "key: currentDashboard.title" and "default: currentDashboard.title" in inline syntax and skip both the quotes and curly braces. -
Claus Due commented on patch set 24 02/09/20, 10:44
locallang.xlf:165I would change this label to remove the jovial style, something like "No widgets in Dashboard" would suffice. -
Claus Due commented on patch set 24 02/09/20, 10:49
Dashboard group "General" is empty (I've got a limited subset of core extensions installed) but is still shown and selected by default. Perhaps empty groups should be hidden? I'm also not sure that the naming "Community" is appropriate (docs and news aren't really "Community" resources). Off the top of my head I'd put all default shipped widgets in the same group and call it "General". -
Claus Due commented on patch set 24 02/09/20, 10:53
Changing the title of a dashboard (through "gears" icon top right) does not appear to actually change the title - the header still says "Dashboard". -
Richard Haeser commented on patch set 24 02/09/20, 12:53
> Patch Set 24: > > Dashboard group "General" is empty (I've got a limited subset of core extensions installed) but is still shown and selected by default. Perhaps empty groups should be hidden? > > I'm also not sure that the naming "Community" is appropriate (docs and news aren't really "Community" resources). Off the top of my head I'd put all default shipped widgets in the same group and call it "General".Grid.ts:29ReplyI can confirm that bug. Will check if we can fix that. For me it only appears when I have a vertical scrollbar. Do you also have some more info regarding browser etc?WidgetContentCollector.ts:35ReplyGood catch! Will add that.DashboardTemplate.php:20ReplyWell, it is a collection of widgets in a specific order so you can kickstart a users dashboard. Looks like a template to me, but I am with you that it can be confusing as we already have several "templates". I think preset is the best option. Will do a rename.AbstractRssWidget.php:18Reply UnresolvedI can see your point. Yes we need a lot of code and even PHP-extensions. Only thing I had was that it was one of the only ways to stay in contact with the real user. If I open WordPress, I also get an overview with news and events around WordPress. Another reason why I added this widget was because almost every user I have spoken, wants to implement RSS feeds. So why not make sure to have a proper abstract so creating RSS widgets is a lot easier. In the end if you don't want to have such a widget in your installation, you can just make sure the user doesn't have the permission.T3GeneralInformation.php:33ReplyGuilty! Will fix that.locallang.xlf:165Reply UnresolvedYes, is "out-of-style" indeed.Main.html:161Reply UnresolvedYou are right that we need to check. Strange thing is, that when the template is rendered, you should never have no dashboard. If you have no dashboard, a new one should automatically be created.RssWidget.html:10Reply UnresolvedIn last patchset it is already changed. It is based on the same code as belog now, but omitting it might be better indeed.ext_tables.php:7Reply UnresolvedAlready changed if you check last patchset. It is moved to the toolbar now. Still reachable within 1 click and from every view, but not on a location people were used to have another module. -
Richard Haeser commented on patch set 24 02/09/20, 12:55
> Patch Set 24: > > Dashboard group "General" is empty (I've got a limited subset of core extensions installed) but is still shown and selected by default. Perhaps empty groups should be hidden? > > I'm also not sure that the naming "Community" is appropriate (docs and news aren't really "Community" resources). Off the top of my head I'd put all default shipped widgets in the same group and call it "General". 1. Will check for empty groups indeed. 2. I didn't want to make them to important by adding them to the general group. Maybe better rename the group to TYPO3? As they are widgets showing information about TYPO3. -
Richard Haeser commented on patch set 24 02/09/20, 12:56
> Patch Set 24: > > Changing the title of a dashboard (through "gears" icon top right) does not appear to actually change the title - the header still says "Dashboard". Well, funny thing is that Dashboard is not the name of the dashboard but of the module. We decided to hide the name of the dashboard when only 1 dashboard is active. But is seems that that is a bit to confusing, so we will always show name of dashboard. Will add to next patchset. -
Richard Haeser uploaded patch set 25 02/09/20, 13:31
-
Richard Haeser uploaded patch set 26 02/09/20, 14:24
-
Richard Haeser commented on patch set 26 02/09/20, 14:25
WidgetContentCollector.ts:35ReplyDoneDashboardTemplate.php:20ReplyDoneT3GeneralInformation.php:33ReplyDone -
Daniel Siepmann commented on patch set 26 02/09/20, 17:32
For whatever reason (didn't dig into it), it is not possible to highlight any content of an widget. This way I can't copy the error message or any RSS Feed content, and can't paste into a chat, content, or E-Mail.dashboard.scss:18For whatever reason (didn't dig into it), it is not possible to highlight any content of an widget. This way I can't copy the error message or any RSS Feed content, and can't paste into a chat, content, or E-Mail. Maybe not an css but js issue?Grid.ts:29Reply73.0 (64-bit) for Ubuntu. Resolution of Display: 3840x2160 Width is only limited through scollbar, there is nothing else as UI or co which reduces the display width, no window border or OS stuff like menu bars. Looks like it only occurs when scrollbar is active 👍dashboard-action-close.svg:1Why do we use a different icon "(x)" instead of an trash, and wording "close" for a widget then for an dashboard "trash" and "Delete dashboard"? If there is no reason, I would propose to streamline both to a trash icon and use "Delete widget" to keep in sync with "Delete dashboard". -
Richard Haeser uploaded patch set 27 02/10/20, 08:44
-
Richard Haeser commented on patch set 27 02/10/20, 08:48
dashboard.scss:18ReplyFixed. Because the drag / drop library also has the possibility to make the complete element draggable, they by default disable text-selection. No reenabled user-select in CSS. As the text gets selected when dragging, we disable the user-select when dragging and reenable it again when the element is released.Grid.ts:29ReplyI think it is fixed now. At least, I can't reproduce anymore with latest patchset. Can you confirm?dashboard-action-close.svg:1ReplyIt is a difference. A dashboard really gets deleted and a widget is only removed from the current dashboard. But I guess having to explain that doesn't make sense, so I changed to use the trash icon also for removing the widget from the current dashboard. -
Richard Haeser uploaded patch set 28 02/10/20, 15:27
-
Daniel Siepmann commented on patch set 28 V +1 02/10/20, 16:06
dashboard.scss:18ReplyDoneGrid.ts:29ReplyDonedashboard-action-close.svg:1ReplyDone -
Richard Haeser uploaded patch set 29 02/10/20, 19:48
-
Richard Haeser uploaded patch set 30 02/11/20, 07:29
-
Georg Ringer voted on patch set 30 V +1 CR +1 02/11/20, 10:40
-
Daniel Siepmann voted on patch set 30 V +1 02/11/20, 11:41
-
Anja Leichsenring commented on patch set 30 02/11/20, 12:36
I currently click around in my new Dashboard, thank you for all that work. Very nice indeed. Here are my nitpicks: 1. There is a big headline 'Dashboard' and next buttons that represent my configured dashboards. This headline does not contain any helpful info, I would prefer the title of the current dashboard taking this spot and only the not active boards get their buttons. 2. The drag & drop positioning feels a little awkward. I can't position a widget in the first or last position of a column. I can't have the second column empty (playing with the default dashboard here) and place all widgets into first column. this is of course all minor stuff, you are welcome to shrug it off. Stating it just in case. And here I am already with a big feature request: will it be possible to adjust display colors in dashboard, e.g. via Extension Settings? First thing I would probably do is getting rid of this orange buttons. -
Anja Leichsenring commented on patch set 30 V +1 CR -1 02/11/20, 13:29
- in be_groups form, tab Access List, section Modules the icon is missing for dashboard. - the icon in the dashboard setup modal (where you select the preset) for the default dashboard resembles a checkbox. My first instinct was it to check it in order the empty dashboard (which is the only one available at this point). So I think the icon for the empty dashboard should be improved to give a better hint of its usage (not being a checkbox to be checked, but a preview). No concrete idea, though. I vote -1 because of the accessibleMock usage, but from my side a low bow for all the work involved and the great outcome. Thanks everybody involved.WidgetAjaxController.php:64should those messages maybe be translatable?AbstractCtaButtonWidget.php:25I'd prefer to have this values empty in the abstract class. With this as is, an empty child class provides everything needed for typo3.org CTA. Not very abstract.AbstractWidget.php:26It is possible to extend ... provides some more specific widget classes to extend from just some wordinglocallang_mod.xlf:10widgets (plural) from extensions wordingWidgetGroupRepositoryTest.php:71first parameter: $expected, second parameter: $actual. Doesn't matter here that much, but the method receives their parameter in wrong order.WidgetRepositoryTest.php:41please don't do this. AccessibleMock is a construct that should not be used since so many years and is only left to us because we still have tests using it, but you should not use it in new code. Solution here: set $GLOBALS['BE_USER] = $this->beUserProphecy; Then you can go with a simple GU::makeInstance(WidgetRepository::class); -
Richard Haeser commented on patch set 30 02/11/20, 15:22
WidgetAjaxController.php:64Reply UnresolvedThis is not shown to a user, so IMO it is not needed to make it translatable. But you got another point and that is that this error result is not fetched and handled in frontend. Will check!AbstractCtaButtonWidget.php:25Reply UnresolvedYou've got a point. Will change thatAbstractWidget.php:26ReplyAcklocallang_mod.xlf:10ReplyAckWidgetGroupRepositoryTest.php:71ReplyAckWidgetRepositoryTest.php:41Reply UnresolvedNot an expert on writing tests, so thanks for your feedback. Checking the wrong example files will lead into this kind of things. Will fix it and otherwise I will check with you. -
Richard Haeser uploaded patch set 31 02/11/20, 15:34
-
Richard Haeser uploaded patch set 32 02/11/20, 19:49
-
Richard Haeser commented on patch set 32 02/11/20, 19:58
> Patch Set 30: > > I currently click around in my new Dashboard, thank you for all that work. Very nice indeed. > > Here are my nitpicks: > 1. There is a big headline 'Dashboard' and next buttons that represent my configured dashboards. This headline does not contain any helpful info, I would prefer the title of the current dashboard taking this spot and only the not active boards get their buttons. > > 2. The drag & drop positioning feels a little awkward. I can't position a widget in the first or last position of a column. I can't have the second column empty (playing with the default dashboard here) and place all widgets into first column. > > this is of course all minor stuff, you are welcome to shrug it off. Stating it just in case. > > And here I am already with a big feature request: will it be possible to adjust display colors in dashboard, e.g. via Extension Settings? First thing I would probably do is getting rid of this orange buttons. 1. We can change that indeed, but is it still clear it is a dashboard in that case? 2. Yes I have been struggling a little bit with it as well. My experience with testing with some people is that they get quite fast used to it. There is a logic behind it, but it is hard to describe that. About your feature request: you can already do that, just the way you can style rest of the backend. $GLOBALS['TBE_STYLES']['skins']['demo_extension']['stylesheetDirectories']['dashboard'] = 'EXT:demo_extension/Resources/Public/CSS/Backend/'; -
Richard Haeser uploaded patch set 33 02/11/20, 20:01
-
Richard Haeser uploaded patch set 34 02/11/20, 20:17
-
Benni Mack commented on patch set 34 02/11/20, 22:29
Overall looking good. I'd love to have more feedback within the RST on how to configure a dashboard, and how to create widgets, what widgets are shipped by default etc.AbstractItemProvider.php:392FYI: we're introducing a cross-dependency here...be_groups.php:227shouldn't this go into EXT:dashboard?ext_localconf.php:8we should move most of the Registration (for dashboards + widgets) into services.yaml to reduce the logic within the ext_localconf and make it available "on demand" / "when needed". have to come up with a factory for this though.ext_tables.sql:4open question: should we rather use "sys_dashboard", or "be_dashboard? We tried to reduce it to singular in latest additions like "sys_redirect" - I'm undecided here. -
Claus Due commented on patch set 34 02/11/20, 23:00
ext_localconf.php:8ReplyWe had this discussion and it was yaml-based for a while, but reverted to the current method. Moving this to yaml-only has major drawbacks like not being able to modify the widgets based on other configuration. Having icon identifiers and static things like that would be completely okay and desirable (but afaik isn't possible yet and perhaps we don't want to start inventing new features for that at this point?). But please refraing from (again) moving widget and dashboard registrations to yaml. There's even an example of such dynamic registration being necessary: the last widget is only loaded if EXT:about is available. The need for a new factory should also hint at yaml perhaps not being the best idea, at least for this specific type of implementation registration. -
Claus Due commented on patch set 34 02/11/20, 23:01
be_groups.php:227ReplyI agree here. If EXT:dashboard isn't installed this adds a field with no function. -
TYPO3com voted on patch set 34 V -1 02/12/20, 08:45 Completed build in 21s on Wed, 12 Feb, 08:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8
-
Benni Mack commented on patch set 34 02/12/20, 19:32
ext_localconf.php:8Replyhmm, I don't know if we're talking about the same thing here. My intention here is to use a factory and service providers instead of putting everything in ext_localconf.php. Why? Because this is then built at built-time and reduces to call the same code again and again (= populating Dashboard Presets here) at runtime. We've done a similar thing with e.g. Configuration/Routes.php in January, which still IS PHP for registering them but is now loaded when needed, and built only once. So if you're ok with this, I'd rather have a factory in the ServiceProvider for loading it. -
Richard Haeser uploaded patch set 35 02/12/20, 21:58
-
TYPO3com voted on patch set 35 V -1 02/12/20, 21:59 Completed build in 22s on Wed, 12 Feb, 09:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20
-
Richard Haeser commented on patch set 35 02/12/20, 22:02
AbstractItemProvider.php:392ReplyFixed by using itemsProcFunc in dashboard extensionbe_groups.php:227ReplyDoneext_tables.sql:4Reply UnresolvedI've changed it to be_dashboard as this has nothing to do with the system but everything with the backend. So good idea! -
Richard Haeser uploaded patch set 36 02/12/20, 22:06
-
TYPO3com voted on patch set 36 V -1 02/12/20, 22:07 Completed build in 09s on Wed, 12 Feb, 10:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21
-
TYPO3com commented on patch set 36 02/12/20, 22:09 Completed build in 08s on Wed, 12 Feb, 10:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22
-
Richard Haeser uploaded patch set 37 02/12/20, 22:12
-
TYPO3com voted on patch set 37 V -1 02/12/20, 22:26 Completed build in 13m 01s on Wed, 12 Feb, 10:26 PM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23
-
TYPO3com commented on patch set 36 02/12/20, 22:26 Completed build in 08s on Wed, 12 Feb, 10:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24
-
TYPO3com commented on patch set 37 02/12/20, 22:41 Completed build in 12m 37s on Wed, 12 Feb, 10:41 PM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25
-
Anja Leichsenring uploaded patch set 38 02/13/20, 08:43
-
Anja Leichsenring uploaded patch set 39 02/13/20, 08:50
-
TYPO3com voted on patch set 38 V -1 02/13/20, 08:57 Completed build in 13m 23s on Thu, 13 Feb, 08:57 AM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27
-
TYPO3com voted on patch set 39 V +1 02/13/20, 09:12 Completed build in 13m 57s on Thu, 13 Feb, 09:12 AM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28
-
Anja Leichsenring commented on patch set 39 02/13/20, 09:13
I satisfied bamboo, but the whole registration topic is still open. -
Richard Haeser commented on patch set 39 02/13/20, 09:20
Thanks Anja. Benni will work on that today. -
Richard Haeser uploaded patch set 40 02/13/20, 15:19
-
TYPO3com voted on patch set 40 V -1 02/13/20, 15:31 Completed build in 12m 36s on Thu, 13 Feb, 03:31 PM Test Summary: 10 of 71832 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-52
-
TYPO3com voted on patch set 40 V +1 02/13/20, 15:46 Completed build in 13m 11s on Thu, 13 Feb, 03:46 PM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-53
-
Richard Haeser uploaded patch set 41 02/13/20, 20:58
-
TYPO3com voted on patch set 41 V +1 02/13/20, 21:35 Completed build in 22m 09s on Thu, 13 Feb, 09:35 PM Test Summary: 71381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-57
-
Richard Haeser uploaded patch set 42 02/13/20, 22:14
-
TYPO3com voted on patch set 42 V +1 02/13/20, 22:27 Completed build in 12m 50s on Thu, 13 Feb, 10:27 PM Test Summary: 71382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-58
-
Frank Nägler commented on patch set 42 CR -1 02/14/20, 12:52
I was not able to test the dashboard module because of a fluid error: (1/1) #1257246929 TYPO3Fluid\Fluid\View\Exception\InvalidTemplateResourceException Tried resolving a template file for controller action "Standard->Dashboard/main" in format ".html", but none of the paths contained the expected template file (Standard/Dashboard/main.html). The following paths were checked: /Volumes/Workspace/t3master/public/typo3/sysext/dashboard/Resources/Private/Templates/ Apart from that, I am deeply disappointed that the YAML configuration concept/feature has been removed. The introduction of repositories as singleton is IMHO a bad idea. Anyway if this is the consent I will not block it.AbstractWidget.php:85Unresolvedlooks like this method is not used?AbstractWidget.php:105looks like this method is not used?AbstractWidget.php:110Unresolvedlooks like this method is not used?AbstractWidget.php:121Unresolvedlooks like this method is not used?DashboardPresetRepository.php:34constructor has only six arguments, but seven used here. -
Richard Haeser commented on patch set 42 02/14/20, 13:04
> Patch Set 42: Code-Review-1 > > (5 comments) > > I was not able to test the dashboard module because of a fluid error: > (1/1) #1257246929 TYPO3Fluid\Fluid\View\Exception\InvalidTemplateResourceException > > Tried resolving a template file for controller action "Standard->Dashboard/main" in format ".html", but none of the paths contained the expected template file (Standard/Dashboard/main.html). The following paths were checked: /Volumes/Workspace/t3master/public/typo3/sysext/dashboard/Resources/Private/Templates/ > > Apart from that, I am deeply disappointed that the YAML configuration concept/feature has been removed. The introduction of repositories as singleton is IMHO a bad idea. > Anyway if this is the consent I will not block it. AH I think you have found a case sensitive issue! Thanks for that! The YAML config part is discussed in the last core-mergers meeting and the decision is made to have a solution that is not only depending on YAML configuration. So I think that shouldn't be a discussion here anymore ;-) -
Richard Haeser uploaded patch set 43 02/14/20, 13:22
-
Richard Haeser commented on patch set 43 02/14/20, 13:24
AbstractWidget.php:105ReplyThe properties are protected and can not be accessed without these getters. We use this attributes in the fluid template. When removing it, you get things like: Cannot access protected property TYPO3\CMS\Dashboard\Widgets\T3GeneralInformation::$heightDashboardPresetRepository.php:34ReplyDone -
TYPO3com voted on patch set 43 V +1 02/14/20, 13:35 Completed build in 12m 53s on Fri, 14 Feb, 01:35 PM Test Summary: 71364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-74
-
Frank Nägler commented on patch set 43 02/14/20, 15:05
> The YAML config part is discussed in the last core-mergers meeting and the decision is made to have a solution that is not only depending on YAML configuration. So I think that shouldn't be a discussion here anymore ;-) No decision was made against YAML at the meeting. Only tasks were defined for a configuration concept. But clearly no decision against YAML. -
Georg Ringer voted on patch set 43 V +1 CR +1 02/14/20, 18:58
-
Benni Mack commented on patch set 43 CR -1 02/14/20, 20:05
yarn.lock:9684this dependency is built on the "apache-2.0" license which states that it is incompatible with GPL1+2, but only compatible with GPL3. I'm not 100% sure if this would affect to make our package "GPL3" effectively, which might conflict with other code that is GPL2 (not GPL2+).AbstractController.php:23can you explain: why is this `web_dashboard`? -
Benni Mack commented on patch set 43 02/14/20, 20:10
ext_localconf.php:45shouldn't we use userTS for this instead? This way we could get rid of TypoScript in BE and have a bit less of Extbase in this extension, and this allows us to configure the option on a per-user / per-usergroup basis? -
Alexander Schnitzler commented on patch set 43 CR -1 02/15/20, 13:36
AbstractController.php:21Let's make this abstract. You can't really do much with an instance of this class.DashboardController.php:187> $this->settings does not exist. -
Richard Haeser uploaded patch set 44 02/16/20, 09:23
-
Richard Haeser commented on patch set 44 02/16/20, 09:31
yarn.lock:9684Reply UnresolvedRemoved this library. This is the "official" polyfill library to make sure Web Animations API works in browsers that don't support this API yet. As you can see on https://caniuse.com/#feat=web-animation this is only a small portion of browsers, but a rather important one, Safari has no out-of-the-box support yet, only as an experimental feature. For now I replaced this with a small lightweight, MIT-licensed library. I think we can remove this polyfill in v11, but we have to check browser-support over time.AbstractController.php:21ReplyDoneAbstractController.php:23Reply UnresolvedA left-over from a refactor from being a module below Web ;-)DashboardController.php:187ReplyGood catch. Thnx!ext_localconf.php:45Reply UnresolvedChanged to userTS as it indeed is even more flexible! -
TYPO3com voted on patch set 44 V +1 02/16/20, 09:54 Completed build in 30m 02s on Sun, 16 Feb, 09:54 AM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-161
-
Andreas Kienast commented on patch set 44 02/16/20, 15:19
locallang.xlf:6UnresolvedPlease add the "resname" attribute to the labels -
Andreas Kienast commented on patch set 44 V -1 02/16/20, 16:04
It seems adding widgets from 3rd party extensions doesn't work. I've created a DashboardWidgets.php and a DashboardWidgetsGroups.php but neither configuration is available after flushing caches. -
Alexander Schnitzler commented on patch set 44 02/16/20, 18:15
DashboardController.php:187ReplyDon't thank me. Thank phpstan. ^^ -
Richard Haeser commented on patch set 44 02/17/20, 07:52
> Patch Set 44: Verified-1 > > It seems adding widgets from 3rd party extensions doesn't work. I've created a DashboardWidgets.php and a DashboardWidgetsGroups.php but neither configuration is available after flushing caches. Sorry, should have mentioned that. Benni will have a look at that. -
Benni Mack uploaded patch set 45 02/17/20, 09:35
-
TYPO3com voted on patch set 45 V +1 02/17/20, 09:54 Completed build in 15m 12s on Mon, 17 Feb, 09:54 AM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-192
-
Claus Due uploaded patch set 46 02/17/20, 13:49
-
TYPO3com voted on patch set 46 V -1 02/17/20, 13:50 Completed build in 12s on Mon, 17 Feb, 01:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-204
-
Richard Haeser uploaded patch set 47 02/17/20, 13:59
-
Richard Haeser commented on patch set 47 CR -1 02/17/20, 14:00
Working on Service Provider enhancements -
TYPO3com voted on patch set 47 V -1 02/17/20, 14:03 Completed build in 27s on Mon, 17 Feb, 02:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-208
-
Frank Nägler wrote 02/17/20, 14:09
Removed reviewer Frank Nägler. -
Richard Haeser uploaded patch set 48 02/17/20, 14:40
-
Richard Haeser updated the commit message in patch set 49 02/17/20, 14:42
-
TYPO3com voted on patch set 48 V +1 02/17/20, 14:54 Completed build in 13m 21s on Mon, 17 Feb, 02:54 PM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-209
-
TYPO3com voted on patch set 49 V +1 02/17/20, 15:00 Completed build in 14m 58s on Mon, 17 Feb, 03:00 PM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-210
-
Andreas Kienast commented on patch set 49 02/17/20, 15:07
WidgetWithTitle.html:3IMO it's not clear enough I have to pass {title} from my own widget, with caused Fluid exceptions here. -
Claus Due commented on patch set 49 02/17/20, 15:10
WidgetWithTitle.html:3ReplyAs previously mentioned, this and any other cases which use dynamic values with f:translate should always have a condition around them to at least confirm the dynamic variable is non-empty.ext_localconf.php:8ReplyThis sounds like a sensible compromise - I have no further objections! -
Richard Haeser commented on patch set 49 02/17/20, 15:12
WidgetWithTitle.html:3ReplyWhat do you think? Better to do translation in the controller so the logic is there? -
Claus Due commented on patch set 49 02/17/20, 15:13
WidgetWithTitle.html:3ReplyThat would make sense imho. That also allows you to do fallback and render a default title or the XLF label path if a value cannot be resolved. -
Richard Haeser uploaded patch set 50 02/17/20, 15:39
-
Richard Haeser commented on patch set 50 02/17/20, 15:41
WidgetWithTitle.html:3ReplyAll logic is now in the PHP classes. -
Claus Due commented on patch set 50 02/17/20, 15:48
WidgetWithTitle.html:3Reply UnresolvedDefinitely a less error prone solution and friendlier for devs, too :) -
TYPO3com voted on patch set 50 V +1 02/17/20, 15:55 Completed build in 15m 34s on Mon, 17 Feb, 03:55 PM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-213
-
Richard Haeser uploaded patch set 51 02/17/20, 16:08
-
TYPO3com voted on patch set 51 V +1 02/17/20, 16:22 Completed build in 13m 11s on Mon, 17 Feb, 04:22 PM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-214
-
Daniel Siepmann commented on patch set 51 02/17/20, 16:38
Grid.ts:28Right now I'm not able to place two rss widgets side by side. Place one below the other and reloading, displays both side by side. Firefox 73.0 (64-bit) with 2560x1440 resolution. Module bar open, and scroll bar in content area of dashboard active. -
Richard Haeser uploaded patch set 52 02/17/20, 20:46
-
Richard Haeser commented on patch set 52 02/17/20, 20:48
Grid.ts:28ReplyThe items were taking too much space. Gave them a little less space and it is working fine now as far as I can see. -
TYPO3com voted on patch set 52 V +1 02/17/20, 21:15 Completed build in 24m 03s on Mon, 17 Feb, 09:15 PM Test Summary: 71415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-225
-
Riny van Tiggelen voted on patch set 52 V +1 CR +1 02/18/20, 06:18
-
Koen Wouters voted on patch set 52 V +1 CR +1 02/18/20, 07:31
-
Rudy Gnodde voted on patch set 52 V +1 02/18/20, 08:47
-
Kevin Appelt uploaded patch set 53 02/18/20, 13:28
-
TYPO3com voted on patch set 53 V +1 02/18/20, 13:44 Completed build in 15m 45s on Tue, 18 Feb, 01:44 PM Test Summary: 71462 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-243
-
Kevin Appelt uploaded patch set 54 02/18/20, 14:03
-
Kevin Appelt uploaded patch set 55 02/18/20, 14:13
-
Kevin Appelt commented on patch set 55 02/18/20, 14:16
Main.html:142UnresolvedI am not sure, but I think <div> is not allowed inside <label> See: https://html.spec.whatwg.org/multipage/forms.html#the-label-element Any opinions? -
TYPO3com voted on patch set 54 V +1 02/18/20, 14:17 Completed build in 13m 49s on Tue, 18 Feb, 02:17 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-246
-
Koen Wouters commented on patch set 55 02/18/20, 14:24
> Patch Set 55: > > (1 comment) Kevin good catch. A div inside a label is not valid. It can be replaced with a span. Maybe it needs some block styling after the tag switch. -
TYPO3com voted on patch set 55 V +1 02/18/20, 14:37 Completed build in 22m 18s on Tue, 18 Feb, 02:37 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-249
-
Kevin Appelt uploaded patch set 56 02/18/20, 19:18
-
Richard Haeser commented on patch set 56 CR -1 02/18/20, 19:21
Missing compiled stylesheet. I'm on it -
Benjamin Franzke commented on patch set 55 02/18/20, 19:31
DashboardWidgets.php:4Instead of this configuration file I would prefer a Services.yaml configuration via tags (Services.php is then supported as well) – basically the same as we have for PSR-14 events: TYPO3\CMS\Dashboard\Widgets\DocumentationWidget: tags: - name: dashboard.widget identifier: documentation groups: typo3, general The advantage is, that service configuration (dependencies) and service registration can be combined in one file. Richard, do you think you could integrate a compiler pass like TYPO3\CMS\Core\DependencyInjection\ListenerProviderPass, or should I try to add that? Note that this compiler pass could live in the dashboard extension TYPO3\CMS\Dashboard\DependencyInjection\DashboardWidgetProviderPass – it would be registered in EXT:dashboard/Configuration/Services.php -
Richard Haeser uploaded patch set 57 02/18/20, 19:36
-
Richard Haeser commented on patch set 57 02/18/20, 19:37
DashboardWidgets.php:4ReplyThanks for the feedback. As discussed on Slack: if you can give it a try, that would be awesome! -
TYPO3com voted on patch set 56 V -1 02/18/20, 19:38 Completed build in 15m 42s on Tue, 18 Feb, 07:38 PM Test Summary: 71458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-263
-
Benjamin Kott commented on patch set 57 V -1 CR -1 02/18/20, 19:45
As discussed with Richard, will do some styling adjustments now. -
TYPO3com voted on patch set 57 V -1 02/18/20, 20:02 Completed build in 21m 31s on Tue, 18 Feb, 08:02 PM Test Summary: 1 of 71914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-266
-
Benjamin Franzke commented on patch set 57 02/18/20, 21:13
WidgetInterface.php:12We should avoid constructors to be defined in interfaces, as interfaces shouldn't specify the implementation. If we have identifiers (and maybe later settings?) we either need to pass these to the relevant get/render/etc Methods, or rather create a WidgetFactoryInterface. For now __construct needs to be dropped. (Will prepare a patch) -
Benjamin Kott uploaded patch set 58 02/19/20, 02:35
-
TYPO3com voted on patch set 58 V -1 02/19/20, 02:49 Completed build in 13m 07s on Wed, 19 Feb, 02:49 AM Test Summary: 61313 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-285
-
Benjamin Franzke commented on patch set 58 02/19/20, 06:54
Currently we have a bit of a mixture of terms: DashboardRegistry vs $dashboardRepository WidgetRegistry vs $widgetRepository As DashboardRegistry reads from the storage (database), it should be DashboardRepository (both in variable and in class names). As WidgetRegistry is configured through extensions it is a classic Registry and should therefore be WidgetRegistry (both in variable and in class names)WidgetAjaxController.php:63As soon as per-widget-instance configuration settings (set in db, user specific) will be available, we would need widget hash instead of the generic widget identifier here, to be able to pass the specific configuration to the widget. How configuration will be passed to the widget is currently unspecified. We'll need to specifiy that right now, as we can't really change the interface later on.AbstractRssWidget.php:27missing empty line after this one.AbstractRssWidget.php:36This hides the fact that we have a dependency and have a bit of a conceptional issue here. Widgets are handled like prototypes (the only possible constructor argument currently is the identifier). That prevents dependencies from being injected. We have two options: * Refactor to services – means widget would be stateless, all state (user configuration) would need to be passed to all the relevant WidgetInterface methods * Mixed Prototypes (using Symfony `shared: false` setting). That would allow to have multiple widget instances of the same class. $identifier (and later $config) would then need to be set via setter Methods like `setConfig` and `setIdentifier`. I prefer the service aproach as in PSR-15 request handlers, but that'll require quite some refactoring :(AbstractRssWidget.php:54Newer core-code uses the TYPO3\CMS\Core\Http\RequestFactory::request() method to perform HTTP requests. GeneralUtility::getUrl hides the fact that this depends on a HTTP-Client service class. We can change that late on, though..Main.html:28WidgetInterface does not contain getId(). I guess this is a left-over. -
Richard Haeser commented on patch set 58 02/19/20, 07:09
> Patch Set 58: > > (5 comments) > > Currently we have a bit of a mixture of terms: > > DashboardRegistry vs $dashboardRepository > WidgetRegistry vs $widgetRepository > > As DashboardRegistry reads from the storage (database), it should be DashboardRepository (both in variable and in class names). > As WidgetRegistry is configured through extensions it is a classic Registry and should therefore be WidgetRegistry (both in variable and in class names) Will create new patch for thatWidgetAjaxController.php:63Reply UnresolvedAfter some thinking this night, I think we will drop the future-feature of configuration per widget. I will remove that part in the current code. -
Richard Haeser commented on patch set 58 02/19/20, 07:17
AbstractRssWidget.php:36ReplyI will refactor code a bit to get rid of the identifiers in the construct so we can use DI for the CacheManager. Would that be sufficient for now?AbstractRssWidget.php:54Reply UnresolvedWill have a look at thatMain.html:28ReplyWill check if we still need it -
Benjamin Franzke uploaded patch set 59 02/19/20, 08:12
-
Benjamin Franzke commented on patch set 59 02/19/20, 08:21
AbstractRssWidget.php:27ReplyDoneAbstractRssWidget.php:36ReplyJust pushed a patchset that does this. The identifier is still pushed though the constructor, but the constructor is no longer part of the interface. In my opinion it could even be hardcoded into getIdentifier() for most widgets. Only widgets that are intended to be multiplexed for multiple identifiers could offer $identifier als constructor parameter. Anyway, that's a widget implementation detail from now on, and could be changed. For this special case (Abstract rss class) it's fine to keep it in the constructor. Though the class that extends the Abstract class could not simply call `parent::__construct('my-identifier')`.WidgetInterface.php:12ReplyDoneDashboardWidgets.php:4ReplyAdded an implementation for this in patchset 59.Main.html:28ReplyI removed it for now, it was actually empty in the rendered template.ext_localconf.php:8ReplyEverything that can be configured in Services.yaml can be configured in Services.php as well. Therefore we now switch to Services.{yaml,php} as initially suggest by Benni. -
TYPO3com voted on patch set 59 V -1 02/19/20, 08:28 Completed build in 15m 31s on Wed, 19 Feb, 08:28 AM Test Summary: 78 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-291
-
Richard Haeser uploaded patch set 60 02/19/20, 14:47
-
TYPO3com voted on patch set 60 V +1 02/19/20, 15:01 Completed build in 13m 51s on Wed, 19 Feb, 03:01 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-309
-
Richard Haeser uploaded patch set 61 02/19/20, 15:02
-
Richard Haeser commented on patch set 61 02/19/20, 15:15
After discussion with Benni we made some decisions: - Current approach is fine to go on - We moved the link to the dashboard to the module bar again as it is a module and is the starting point of the backend - Registration of widgets is done in Configuration/Services.yaml/php - Registration of Dashboard Presets and Widget Groups are done in Configuration/Backend/DashboardPresets.php / DashboardWidgetGroups.php -
Mathias Brodala commented on patch set 61 02/19/20, 15:21
DashboardWidgetPass.php:64UnresolvedWe could require an array here or am I wrong?Services.yaml:24Can we rename this to "widgetGroups" to not have a too generic (and thus confusing) term here? And shouldn't we represent this as YAML list instead? -
TYPO3com voted on patch set 61 V +1 02/19/20, 15:22 Completed build in 15m 33s on Wed, 19 Feb, 03:22 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-312
-
Kevin Appelt commented on patch set 61 CR -1 02/19/20, 15:30
Main.html:143<div> in <label> was removed earlier but reintroduced. -
Richard Haeser commented on patch set 61 02/19/20, 15:32
Services.yaml:24ReplyThat might be a good one. Will change it.Main.html:143ReplyAH strange. Will fix that indeed. -
Koen Wouters commented on patch set 61 V -1 CR -1 02/19/20, 15:42
_header.scss:55There is a strange underline on hover of this button_modal.scss:55The description of dashboards in the add dashboard modal is bold and should be normal like the add widget modal.DashboardToolbarItem.js:1Shouldn't this file be removed? -
Richard Haeser uploaded patch set 62 02/19/20, 16:02
-
Koen Wouters voted on patch set 62 V +1 CR +1 02/19/20, 16:05
-
Richard Haeser commented on patch set 62 02/19/20, 16:05
_header.scss:55ReplyDone_modal.scss:55ReplyDoneServices.yaml:24ReplyDoneMain.html:143ReplyDoneDashboardToolbarItem.js:1ReplyDone -
TYPO3com voted on patch set 62 V +1 02/19/20, 16:15 Completed build in 13m 00s on Wed, 19 Feb, 04:15 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-315
-
Richard Haeser uploaded patch set 63 02/19/20, 16:44
-
Koen Wouters voted on patch set 63 V +1 CR +1 02/19/20, 16:44
-
Riny van Tiggelen voted on patch set 63 V +1 CR +1 02/19/20, 16:46
-
TYPO3com voted on patch set 63 V +1 02/19/20, 16:57 Completed build in 13m 10s on Wed, 19 Feb, 04:57 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-316
-
Benjamin Kott commented on patch set 63 V +1 CR +1 02/19/20, 17:06
Styling is fine for now - did most of the cleanups already. Everything else can be handled later. -
Georg Ringer voted on patch set 63 V +1 CR +1 02/19/20, 17:12
-
Georg Ringer voted on patch set 63 V +2 CR +2 02/19/20, 17:12
-
Björn Jacob voted on patch set 63 V +1 CR +1 02/19/20, 17:13
-
Richard Haeser merged patch set 64 02/19/20, 17:14
-
Benjamin Franzke commented on patch set 64 02/19/20, 21:03
Services.yaml:24ReplyWell, I disagree, how can a `groups` attribute for a tag named `dashboard.widget` be too generic? I mean, what other kind of group could be referred to? For me `widgetGroups` is unnecessarily redundant. BTW: yaml lists wouldn't be possible, as they are not supported as symfony tag attribute. -
Alexander Schnitzler commented on patch set 64 02/20/20, 09:17
DashboardController.php:176Post -1 > ------ ------------------------------------------------------------------------------------------------ > Line dashboard/Classes/Controller/DashboardController.php > ------ ------------------------------------------------------------------------------------------------ > 176 Access to an undefined property TYPO3\CMS\Dashboard\Controller\DashboardController::$settings. > ------ ------------------------------------------------------------------------------------------------ -
Richard Haeser commented on patch set 64 02/20/20, 20:45
DashboardController.php:176Reply UnresolvedSomething has gone wrong in a patchset. https://review.typo3.org/c/Packages/TYPO3.CMS/+/63337 -
Mathias Brodala commented on patch set 64 02/21/20, 07:32
Services.yaml:24ReplyYou should consider the context. Here we configure services for DI, so I cannot be sure if "groups" refer to something DI-related or something domain-specific like widget groups. If in doubt, be explicit. ;-) -
Benjamin Franzke commented on patch set 64 02/21/20, 08:26
Services.yaml:24ReplyThere is honestly no doubt, this is about consistency with other DI tags we already have. We never prefixed the tag-type to tag attributes. Now with this case we got an exception for that rule, which means we got inconsistency. I think a property should not named with the intention to educate other developers about DI specific terms. -
Mathias Brodala commented on patch set 64 02/21/20, 08:28
Services.yaml:24Reply UnresolvedIn that case all other locations should be changed to include domain-specific terms IMO. TL;DR: Don't make me think. -
Claus Due commented on patch set 64 02/23/20, 18:51
Post -1: I really dislike the method of putting the dashboard as "web" module and giving it "priority: top". It ruins the UX expectation for users who are using TYPO3 frequently and afaik, there is no option in configuration to even prevent it from being "priority: top"... @Benni, @Richard - should we have a talk about this? -
Benni Mack commented on patch set 64 02/27/20, 08:01
> Patch Set 64: > > Post -1: > > I really dislike the method of putting the dashboard as "web" module and giving it "priority: top". It ruins the UX expectation for users who are using TYPO3 frequently and afaik, there is no option in configuration to even prevent it from being "priority: top"... > > @Benni, @Richard - should we have a talk about this? Hey Claus, this request came in from Benji / UX perspective. Should probably discuss this in the #cig-dashboard channel? -
Mathias Brodala commented on patch set 64 02/27/20, 08:03
> Patch Set 64: > > Post -1: > > I really dislike the method of putting the dashboard as "web" module and giving it "priority: top". It ruins the UX expectation for users who are using TYPO3 frequently and afaik, there is no option in configuration to even prevent it from being "priority: top"... > > @Benni, @Richard - should we have a talk about this? I agree. Just from using the v10 BE a few minutes recently I noticed that I constantly hit the Dashboard module where my muscle memory expected the Page module instead.