63146[BUGFIX] Prevent PHP type error with deprecated settings for mailer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Martin Hotmann +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Martin Hotmann +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 910
-
Simon Gilli uploaded patch set 1 02/02/20, 14:03
-
TYPO3com voted on patch set 1 V +1 02/02/20, 14:13 Completed build in 10m 17s on Sun, 2 Feb, 02:13 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40480
-
Oliver Klee commented on patch set 1 02/02/20, 14:40
Is 9.5 affected as well? (AFAICT, it is, but I'm not 100% sure.) -
Simon Gilli commented on patch set 1 02/02/20, 14:45
Reply Unresolved
No, it uses swiftmailer -
Oliver Klee voted on patch set 1 CR +1 02/02/20, 15:13
-
Andreas Kienast voted on patch set 1 CR +1 02/02/20, 16:18
-
Martin Hotmann voted on patch set 1 V +1 CR +1 02/03/20, 12:30
-
Benni Mack voted on patch set 1 V +2 CR +2 02/03/20, 12:57
-
Benni Mack merged patch set 2 02/03/20, 12:57
-
Benjamin Franzke commented on patch set 2 04/16/20, 17:16
Btw, itDefaultConfigurationDescription.yaml:532UnresolvedThis is still a bit misleading. Symfony wants TLS = true for ssl:// connections, while TLS = false is required for STARTTLS connections (STARTTLS is often referred to as "TLS", also in TYPO3 v9 where it was called 'tls'). Technical background: STARTTLS uses an unencrypted connection, that is upgraded to TLS if the server reports STARTTLS as capability. Not sure whether we should provide a "smooth" migration that sets "transport_smtp_encrypt = false" if it is currently set to "tls". Currently, upgrading from TYPO3 v9 to v10 transport_smtp_encrypt = tls will result in a SSL connection attempt on the TLS port (So it tries to use ssl:// instead of smtp:// + STARTTLS). I've therefore created an issue on forge: https://forge.typo3.org/issues/91070