Review main Merged

63148[BUGFIX] Make user avatar buttons accessible via keyboard

Elias Häußler CR +2 V +2 Easy +4 −4 updated 02/15/20, 07:40

Commit message

Both "clear" and "add" buttons for the backend user avatar selection
are currently not accessible via keyboard. In order to solve this
accessibility issue, both buttons have been converted from links to
html buttons to trigger the onclick handler when using the keyboard.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Elias Häußler uploaded patch set 1 02/02/20, 18:38

  2. TYPO3com voted on patch set 1 V +1 02/02/20, 18:48 Completed build in 10m 16s on Sun, 2 Feb, 06:48 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40489

  3. Michael Telgkamp commented on patch set 1 V +1 CR +1 02/04/20, 15:23

    Thank you for creating this patch. It looks good for me and using the keyboard works as expected now.
  4. Oliver Klee voted on patch set 1 CR +1 02/04/20, 16:58

  5. Andreas Kienast commented on patch set 1 CR -1 02/04/20, 22:26

    Please add type="button" as well, as the default behavior is "submit" (I'm aware we have some JS doing stuff here)
  6. Michael Telgkamp uploaded patch set 2 02/05/20, 10:06

  7. Oliver Klee voted on patch set 2 CR +1 02/05/20, 10:36

  8. Torben Hansen voted on patch set 2 CR +1 02/05/20, 14:51

  9. Oli Bartsch voted on patch set 2 CR +1 02/06/20, 07:00

  10. Michael Telgkamp voted on patch set 2 V +1 02/06/20, 12:16

  11. Torben Hansen voted on patch set 2 V +1 02/09/20, 18:59

  12. TYPO3com voted on patch set 2 V +1 02/14/20, 07:10 Completed build in 14m 58s on Fri, 14 Feb, 07:10 AM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-60

  13. Benni Mack voted on patch set 2 V +2 CR +2 02/15/20, 07:40

  14. Benni Mack merged patch set 3 02/15/20, 07:40