Review main Abandoned

63153[TASK] Make JsonResponse public API

Simon Schaufelberger CR 0 V 0 Easy +0 −2 updated 03/23/20, 20:14

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1011

  1. Simon Schaufelberger uploaded patch set 1 02/02/20, 23:10

  2. Simon Schaufelberger commented on patch set 1 02/02/20, 23:12

    This Class is available since TYPO3 9.0.0 and should be opened as public API
  3. TYPO3com voted on patch set 1 V +1 02/02/20, 23:28 Completed build in 17m 51s on Sun, 2 Feb, 11:28 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40497

  4. Andreas Kienast commented on patch set 1 CR -1 02/03/20, 06:34

    I've forwarded this patch for discussion on whether we want to make that API public now. If yes, more Response classes could be made public.
  5. Simon Schaufelberger commented on patch set 1 02/03/20, 10:47

    @Andreas Right, the RedirectResponse, HtmlResponse and NullResponse should also be discussed.
  6. Simon Schaufelberger commented on patch set 1 02/03/20, 12:19

  7. Benni Mack commented on patch set 1 CR -1 03/06/20, 14:55

    tbh, we should actually make use of the PSR factories and not instantiate the objects directly.
  8. Alexander Schnitzler commented on patch set 1 03/06/20, 20:09

    > Patch Set 1: Code-Review-1 > > tbh, we should actually make use of the PSR factories and not instantiate the objects directly. Indeed. And for that we need to make Extbase PSR-7 compatible first. Will happen in 11.0 when we force actions to return a ResponseInterface. We should always think in interfaces instead of concrete implementations. Then, it doesn't matter if a JsonResponse is marked api, internal or whatever. As long as it implements the ResponseInterface it can be used.
  9. Benni Mack commented on patch set 1 03/06/20, 20:19

  10. Benni Mack commented on patch set 1 03/06/20, 20:19

    if we make this public, we're gonna have a hard time replacing "our" implementations in the wild - and that is the whole purpose of PHP-FIG.
  11. Benni Mack abandoned the change 03/23/20, 20:14

    abandoning this change for the time being, no response