63154[TASK] Improve accessibility of "New form" multi-step wizard
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Sources/Sass/form.scss+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/MultiStepWizard.ts4+14 −0
- typo3/sysext/backend/Resources/Public/JavaScript/MultiStepWizard.js+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager/ViewModel.js2+22 −5
Review log 2736
Show 911 earlier messages
-
Elias Häußler uploaded patch set 1 02/03/20, 00:17
-
TYPO3com voted on patch set 1 V +1 02/03/20, 00:30 Completed build in 13m 21s on Mon, 3 Feb, 12:30 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40498
-
Stephan Großberndt updated the commit message in patch set 2 02/03/20, 09:10
-
Stephan Großberndt commented on patch set 2 02/03/20, 09:12
Nice addition, thanks. Forge issue should contain the problem to solve, patch description should contain what is changed. see https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#commitmessage -
TYPO3com voted on patch set 2 V +1 02/03/20, 09:20 Completed build in 09m 54s on Mon, 3 Feb, 09:20 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40500
-
Elias Häußler wrote 02/19/20, 08:11
Topic set to accessibility -
Björn Jacob commented on patch set 2 02/27/20, 21:55
@elias could you pls rebase the patch? Would love to see this in v10 LTS. -
Oli Bartsch commented on patch set 2 02/28/20, 05:35
MultiStepWizard.ts:247This is never used as far as I can see. Anyway as the two new functions are doing exactly the same, could we just pass the button name (prev / next) to ONE function called something like `triggerStepButton(direction)`? -
Elias Häußler uploaded patch set 3 02/28/20, 09:08
-
Elias Häußler uploaded patch set 4 02/28/20, 09:10
-
Elias Häußler commented on patch set 4 02/28/20, 09:11
MultiStepWizard.ts:247ReplyDone
-
Oli Bartsch commented on patch set 4 02/28/20, 09:16
MultiStepWizard.ts:230Just update the comment :) -
TYPO3com voted on patch set 3 V +1 02/28/20, 09:19 Completed build in 11m 06s on Fri, 28 Feb, 09:19 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-775
-
TYPO3com voted on patch set 4 V +1 02/28/20, 09:25 Completed build in 14m 42s on Fri, 28 Feb, 09:25 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-776
-
Oli Bartsch commented on patch set 4 CR -1 02/28/20, 09:42
On it -
Elias Häußler uploaded patch set 5 02/28/20, 09:42
-
Elias Häußler commented on patch set 5 02/28/20, 09:43
> Patch Set 4: Code-Review-1 > > On it Already pushed seconds ago ;) -
Elias Häußler commented on patch set 5 02/28/20, 09:44
MultiStepWizard.ts:230ReplyDone -
TYPO3com voted on patch set 5 V +1 02/28/20, 09:54 Completed build in 12m 02s on Fri, 28 Feb, 09:54 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-778
-
Oli Bartsch uploaded patch set 6 02/28/20, 10:02
-
Oli Bartsch commented on patch set 6 02/28/20, 10:04
> Patch Set 5: > > > Patch Set 4: Code-Review-1 > > > > On it > > Already pushed seconds ago ;) Ah oke. I furthermore added the focus style also for these elements in the "abstract view". It was not obvious on which element the focus is. -
Oli Bartsch voted on patch set 6 V +1 CR +1 02/28/20, 10:04
-
TYPO3com voted on patch set 6 V -1 02/28/20, 10:13 Completed build in 11m 08s on Fri, 28 Feb, 10:13 AM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-779
-
Oli Bartsch uploaded patch set 7 02/28/20, 10:30
-
TYPO3com commented on patch set 6 02/28/20, 10:33 Completed build in 11m 02s on Fri, 28 Feb, 10:33 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-781
-
TYPO3com voted on patch set 7 V +1 02/28/20, 10:42 Completed build in 12m 06s on Fri, 28 Feb, 10:42 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-782
-
Oli Bartsch commented on patch set 7 V +1 CR +1 02/28/20, 10:44
Sorry had some problems with my local installed yarn packages. -
Andreas Kienast voted on patch set 7 CR +1 02/28/20, 14:21
-
Andreas Kienast commented on patch set 7 CR -1 02/28/20, 14:23
ViewModel.js:336keyCode is deprecated. I'll push a new patch set. -
Andreas Kienast uploaded patch set 8 02/28/20, 14:31
-
Andreas Kienast voted on patch set 8 V +1 CR +1 02/28/20, 14:31
-
TYPO3com voted on patch set 8 V +1 02/28/20, 14:46 Completed build in 13m 42s on Fri, 28 Feb, 02:46 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-793
-
Elias Häußler commented on patch set 8 02/28/20, 14:51
ViewModel.js:336ReplyThanks for taking care of it! -
Oli Bartsch voted on patch set 8 V +1 CR +1 02/28/20, 14:58
-
Andreas Kienast voted on patch set 8 V +2 CR +2 02/28/20, 15:02
-
Andreas Kienast merged patch set 9 02/28/20, 15:02