Review main Merged

63154[TASK] Improve accessibility of "New form" multi-step wizard

Elias Häußler CR +2 V +2 Easy +39 −7 updated 02/28/20, 15:02

Commit message

This patch addds a basic keyboard navigation inside the multi-step wizard
for new forms in backend. This improves handling forms with the multiple
steps in this wizard.

Additionally, most useful input elements, such as input fields and next
step/finalize buttons are now focused by default when going to the next
slide. Also the focus styles were added to these elements.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2736

Show 911 earlier messages
  1. Elias Häußler uploaded patch set 1 02/03/20, 00:17

  2. TYPO3com voted on patch set 1 V +1 02/03/20, 00:30 Completed build in 13m 21s on Mon, 3 Feb, 12:30 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40498

  3. Stephan Großberndt updated the commit message in patch set 2 02/03/20, 09:10

  4. Stephan Großberndt commented on patch set 2 02/03/20, 09:12

    Nice addition, thanks. Forge issue should contain the problem to solve, patch description should contain what is changed. see https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#commitmessage
  5. TYPO3com voted on patch set 2 V +1 02/03/20, 09:20 Completed build in 09m 54s on Mon, 3 Feb, 09:20 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40500

  6. Elias Häußler wrote 02/19/20, 08:11

    Topic set to accessibility
  7. Björn Jacob commented on patch set 2 02/27/20, 21:55

    @elias could you pls rebase the patch? Would love to see this in v10 LTS.
  8. Oli Bartsch commented on patch set 2 02/28/20, 05:35

    MultiStepWizard.ts:247

    This is never used as far as I can see. Anyway as the two new functions are doing exactly the same, could we just pass the button name (prev / next) to ONE function called something like `triggerStepButton(direction)`?
  9. Elias Häußler uploaded patch set 3 02/28/20, 09:08

  10. Elias Häußler uploaded patch set 4 02/28/20, 09:10

  11. Elias Häußler commented on patch set 4 02/28/20, 09:11

    MultiStepWizard.ts:247 Reply

    Done
  1. Oli Bartsch commented on patch set 4 02/28/20, 09:16

    MultiStepWizard.ts:230

    Just update the comment :)
  2. TYPO3com voted on patch set 3 V +1 02/28/20, 09:19 Completed build in 11m 06s on Fri, 28 Feb, 09:19 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-775

  3. TYPO3com voted on patch set 4 V +1 02/28/20, 09:25 Completed build in 14m 42s on Fri, 28 Feb, 09:25 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-776

  4. Oli Bartsch commented on patch set 4 CR -1 02/28/20, 09:42

    On it
  5. Elias Häußler uploaded patch set 5 02/28/20, 09:42

  6. Elias Häußler commented on patch set 5 02/28/20, 09:43

    > Patch Set 4: Code-Review-1 > > On it Already pushed seconds ago ;)
  7. Elias Häußler commented on patch set 5 02/28/20, 09:44

    MultiStepWizard.ts:230 Reply

    Done
  8. TYPO3com voted on patch set 5 V +1 02/28/20, 09:54 Completed build in 12m 02s on Fri, 28 Feb, 09:54 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-778

  9. Oli Bartsch uploaded patch set 6 02/28/20, 10:02

  10. Oli Bartsch commented on patch set 6 02/28/20, 10:04

    > Patch Set 5: > > > Patch Set 4: Code-Review-1 > > > > On it > > Already pushed seconds ago ;) Ah oke. I furthermore added the focus style also for these elements in the "abstract view". It was not obvious on which element the focus is.
  11. Oli Bartsch voted on patch set 6 V +1 CR +1 02/28/20, 10:04

  12. TYPO3com voted on patch set 6 V -1 02/28/20, 10:13 Completed build in 11m 08s on Fri, 28 Feb, 10:13 AM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-779

  13. Oli Bartsch uploaded patch set 7 02/28/20, 10:30

  14. TYPO3com commented on patch set 6 02/28/20, 10:33 Completed build in 11m 02s on Fri, 28 Feb, 10:33 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-781

  15. TYPO3com voted on patch set 7 V +1 02/28/20, 10:42 Completed build in 12m 06s on Fri, 28 Feb, 10:42 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-782

  16. Oli Bartsch commented on patch set 7 V +1 CR +1 02/28/20, 10:44

    Sorry had some problems with my local installed yarn packages.
  17. Andreas Kienast voted on patch set 7 CR +1 02/28/20, 14:21

  18. Andreas Kienast commented on patch set 7 CR -1 02/28/20, 14:23

    ViewModel.js:336

    keyCode is deprecated. I'll push a new patch set.
  19. Andreas Kienast uploaded patch set 8 02/28/20, 14:31

  20. Andreas Kienast voted on patch set 8 V +1 CR +1 02/28/20, 14:31

  21. TYPO3com voted on patch set 8 V +1 02/28/20, 14:46 Completed build in 13m 42s on Fri, 28 Feb, 02:46 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-793

  22. Elias Häußler commented on patch set 8 02/28/20, 14:51

    ViewModel.js:336 Reply

    Thanks for taking care of it!
  23. Oli Bartsch voted on patch set 8 V +1 CR +1 02/28/20, 14:58

  24. Andreas Kienast voted on patch set 8 V +2 CR +2 02/28/20, 15:02

  25. Andreas Kienast merged patch set 9 02/28/20, 15:02