Review main Merged

63161[TASK] Remove title field in redirects module

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 02/03/20, 20:18

Commit message

Redirects do not require a link title, so the title field is removed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Guido Schmechel uploaded patch set 1 02/03/20, 14:35

  2. TYPO3com voted on patch set 1 V +1 02/03/20, 14:48 Completed build in 12m 25s on Mon, 3 Feb, 02:48 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40517

  3. Andreas Kienast commented on patch set 1 CR +1 02/03/20, 18:04

    I fail to reproduce the issue in master, I can only verify the title field is missing for new redirects.
  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/03/20, 19:03

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 02/03/20, 20:18

  6. Daniel Goerz merged patch set 2 02/03/20, 20:18