Review main Merged

63166[TASK] Clean up PageLayoutController

Benni Mack CR +2 V +2 Hard +66 −298 updated 02/03/20, 17:51

Commit message

With PageLayoutView, the PageLayoutController class
shows various options that are not evaluated anymore,
and thus, can be streamlined to make adjustments easier.

The fields "new_unique_uid", "returnUrl" and "popViewId" is not in use in
the Page Module.

The ContentLayoutPagePositionMap (UX for choosing a new
content element in two steps) is not in use anymore since the
modal box (New Content Element Wizard) was added.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Benni Mack uploaded patch set 1 02/03/20, 16:19

  2. TYPO3com voted on patch set 1 V +1 02/03/20, 16:30 Completed build in 10m 31s on Mon, 3 Feb, 04:30 PM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40525

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/03/20, 16:46

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 02/03/20, 17:50

  5. Andreas Kienast merged patch set 2 02/03/20, 17:51