Review main Merged

63167[BUGFIX] Filter undefined values from request payload

Andreas Kienast CR +2 V +2 Normal +87 −3 updated 02/03/20, 17:19

Commit message

To keep compatibility with existing code, the AJAX API now removes
undefined values from any payload (either JSON, FormData or
SearchParams).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 02/03/20, 16:42

  2. Markus Klein commented on patch set 1 02/03/20, 16:47

    InputTransformer.ts:89 Unresolved

    A normal if (typeof ...) delete ..; would be more readable for me
  3. Andreas Kienast uploaded patch set 2 02/03/20, 16:50

  4. Markus Klein voted on patch set 2 V +1 CR +1 02/03/20, 16:53

  5. TYPO3com voted on patch set 1 V +1 02/03/20, 16:53 Completed build in 10m 42s on Mon, 3 Feb, 04:53 PM Test Summary: 71252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40527

  6. Andreas Kienast uploaded patch set 3 02/03/20, 16:55

  7. Markus Klein voted on patch set 3 V +1 CR +1 02/03/20, 16:57

  8. TYPO3com voted on patch set 2 V +1 02/03/20, 17:04 Completed build in 13m 34s on Mon, 3 Feb, 05:04 PM Test Summary: 71253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40529

  9. TYPO3com voted on patch set 3 V +1 02/03/20, 17:07 Completed build in 12m 30s on Mon, 3 Feb, 05:07 PM Test Summary: 71253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40530

  10. Georg Ringer voted on patch set 3 V +2 CR +2 02/03/20, 17:19

  11. Georg Ringer merged patch set 4 02/03/20, 17:19