Review 9.5 Merged

63169[TASK] Avoid Fluid JS escaping trick in new content wizard

Daniel Goerz CR +2 V +2 Easy +6 −3 updated 02/13/20, 09:21

Commit message

Assigns the entire goToalt_doc JS method from the new
content wizard controller, which prevents the need for
using a JS escaping trick in Fluid.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Daniel Goerz uploaded patch set 1 02/03/20, 20:30

  2. TYPO3com voted on patch set 1 V +1 02/03/20, 20:41 Completed build in 11m 09s on Mon, 3 Feb, 08:41 PM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1966

  3. Daniel Goerz commented on patch set 1 CR -1 02/10/20, 09:11

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/63185 needs to be respected in this backport. Will take care later.
  4. Daniel Goerz uploaded patch set 2 02/10/20, 15:48

  5. Daniel Goerz updated the commit message in patch set 3 02/10/20, 15:48

  6. TYPO3com voted on patch set 3 V +1 02/12/20, 09:06 Completed build in 12m 00s on Wed, 12 Feb, 09:06 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-4

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 02/13/20, 09:15

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 02/13/20, 09:21

  9. Daniel Goerz merged patch set 4 02/13/20, 09:21