Review main Merged

63170[TASK] Streamline linkvalidator code

Benni Mack CR +2 V +2 Normal +86 −151 updated 02/04/20, 13:45

Commit message

This is a pre-patch to fluidize the Backend module and the
linkvalidator email as next steps.

- Remove unused functionality
- Move database calls to linkvalidator table into BrokenLinkRepository (incl. json_decode)
- Fix PHP comments and method argument handling

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1

Issues 1

Files 4

Review log 6

  1. Benni Mack uploaded patch set 1 02/04/20, 08:41

  2. Benni Mack updated the commit message in patch set 2 02/04/20, 08:41

  3. Susi Moog voted on patch set 2 V +1 CR +1 02/04/20, 09:10

  4. Daniel Goerz voted on patch set 2 CR +1 02/04/20, 12:40

  5. Georg Ringer voted on patch set 2 V +2 CR +2 02/04/20, 13:45

  6. Georg Ringer merged patch set 3 02/04/20, 13:45