Review main Merged

63172[TASK] Split up PageLayoutView code into smaller chunks

Benni Mack CR +2 V +2 Expert +490 −544 updated 02/10/20, 06:24

Commit message

The PageLayoutView monster class has been chunked up into smaller
parts and some other functionality was removed.

In detail this patch changes:
- start() method is removed, as it is not needed anymore
- public properties which are not in use or have been left-overs ("nextThree") are removed
- rendering a single content element is now split up into smaller parts
- rendering the "localization view" is now separated into a separate method
- unnecessary functionality in separate methods (addPageIdConstraint) is moved into the main SQL function

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1

Issues 1

Files 3

Review log 9

  1. Benni Mack uploaded patch set 1 02/04/20, 09:35

  2. Susi Moog commented on patch set 1 V -1 02/04/20, 09:52

    PageLayoutView.php:740 Unresolved

    PHP Warning: array_walk() expects parameter 1 to be array, null given in /var/www/html/Packages/TYPO3.CMS/typo3/sysext/backend/Classes/View/PageLayoutView.php line 742
  3. Benni Mack uploaded patch set 2 02/04/20, 10:17

  4. Tymoteusz Motylewski commented on patch set 2 02/05/20, 21:43

    Unresolved

    IdConstraint
  5. Benni Mack updated the commit message in patch set 3 02/09/20, 16:39

  6. Georg Ringer voted on patch set 3 V +1 CR +1 02/09/20, 21:11

  7. Daniel Gorges voted on patch set 3 V +1 CR +1 02/10/20, 06:19

  8. Benni Mack voted on patch set 3 V +2 CR +2 02/10/20, 06:24

  9. Benni Mack merged patch set 4 02/10/20, 06:24