Review main Merged

63175[BUGFIX] Fix check for "ifEmpty" relevance

Francois Suter CR +2 V +2 Easy +2 −2 updated 02/28/20, 05:35

Commit message

The ContentObjectRenderer checks whether it is relevant or not to apply
the ifEmpty property before actually applying it. However the check does
not use the same condition as ifEmpty itself (PHP empty() vs trim()).
This patch ensures consistency while respecting the idea of the original
fix (avoid a useless processing).

NOTE: I have inverted the two conditions in the "if" statement following
a recommendation by the Php Inspections plugin of PhpStorm which said
that the condition about "ifBlank" was faster and should be executed
first.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Wolfgang Klinger +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Francois Suter uploaded patch set 1 02/05/20, 08:57

  2. Oliver Klee commented on patch set 1 02/05/20, 09:37

    Can we have regression tests for this?
  3. Wolfgang Klinger voted on patch set 1 CR +1 02/07/20, 10:12

  4. Georg Ringer voted on patch set 1 CR +1 02/14/20, 19:22

  5. Susi Moog voted on patch set 1 CR +1 02/22/20, 18:26

  6. TYPO3com voted on patch set 1 V +1 02/22/20, 19:02 Completed build in 28m 32s on Sat, 22 Feb, 07:02 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-501

  7. Daniel Goerz voted on patch set 1 V +1 CR +1 02/22/20, 21:58

  8. Susi Moog voted on patch set 1 V +2 CR +2 02/28/20, 05:35

  9. Susi Moog merged patch set 2 02/28/20, 05:35