Review main Merged

63176[TASK] Use ModuleTemplate and Fluid for LinkBrowser and ElementBrowser

Benni Mack CR +2 V +2 Hard +126 −192 updated 02/10/20, 06:23

Commit message

This patch removes the dependency to DocumentTemplate from
all LinkHandler + ElementBrowser popups, paving the way
to move HTML generation of these parts into Fluid templates more
and more.

In this iteration however, the main focus relies on using ModuleTemplate
instead of having everything built within Fluid.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1

Issues 1

Files 11

Review log 8

  1. Benni Mack uploaded patch set 1 02/05/20, 11:39

  2. Björn Jacob commented on patch set 1 02/05/20, 12:15

    Super cool. Just one question :)
    Is this 2nd "to move" superfluous?
  3. Benni Mack updated the commit message in patch set 2 02/05/20, 13:50

  4. Benni Mack commented on patch set 2 02/05/20, 13:51

    Reply

    :-D
  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/09/20, 21:10

  6. Daniel Gorges voted on patch set 2 V +1 CR +1 02/10/20, 06:22

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/10/20, 06:23

  8. Benni Mack merged patch set 3 02/10/20, 06:23