Review main Merged

63177[BUGFIX] Add missing identify fields for f:hidden VH

Stefan Froemken CR +2 V +2 Easy +2 −0 updated 02/28/20, 05:31

Commit message

When using only f:hidden fields for sub-properties
of a domain model which has to be updated, no identity
fields (__identity) are generated in HTML which
results in creating new model instead of updating it.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Stefan Froemken uploaded patch set 1 02/05/20, 14:32

  2. Oliver Klee commented on patch set 1 02/05/20, 15:40

    Unresolved

    What is a CH?
  3. Stefan Froemken updated the commit message in patch set 2 02/05/20, 15:50

  4. Stefan Froemken commented on patch set 2 02/05/20, 15:50

    VH for ViewHelper
  5. Daniel Goerz voted on patch set 2 CR +1 02/23/20, 21:09

  6. TYPO3com voted on patch set 2 V +1 02/23/20, 21:37 Completed build in 21m 30s on Sun, 23 Feb, 09:37 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-586

  7. Oli Bartsch voted on patch set 2 CR +1 02/24/20, 06:05

  8. Georg Ringer commented on patch set 2 02/24/20, 06:42

    only master relevant?
  9. Georg Ringer commented on patch set 2 V +1 CR +1 02/24/20, 06:43

    ... forget previous comment
  10. Susi Moog voted on patch set 2 CR +1 02/27/20, 19:37

  11. Susi Moog voted on patch set 2 V +2 CR +2 02/28/20, 05:31

  12. Susi Moog merged patch set 3 02/28/20, 05:31