Review main Merged

6318[BUGFIX] EM: Configuration inlineToWindow does not default to 1

Xavier Perseguers CR +2 V +2 Easy +2 −0 updated 06/03/13, 20:49

Commit message

Default configuration for inlineToWindow is set to 1 in ext_conf_template.txt but
if localconf.php contains an incomplete definition for $TYPO3_CONF_VARS['EXT']['extConf']['em'],
it defaults to 0 instead.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Steffen Ritter +1
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 4

  1. Xavier Perseguers commented on patch set 1 V 0 10/25/11, 11:04

    by team member; Looks good to me, approved Merged as nobrainer
  2. Steffen Ritter commented on patch set 1 10/25/11, 11:04

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 10/25/11, 11:04

  4. Xavier Perseguers merged patch set 1 10/25/11, 11:04