Review main Merged

63180[BUGFIX] Reset variables in SiteListCommand

Georg Ringer CR +2 V +2 Easy +2 −2 updated 02/10/20, 06:10

Commit message

Reset the variables holding information about locale and status to avoid
showing wrong output.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Georg Ringer uploaded patch set 1 02/07/20, 08:43

  2. Georg Ringer uploaded patch set 2 02/07/20, 08:44

  3. Georg Ringer commented on patch set 2 02/07/20, 08:44

    This change is ready for review.
  4. Wittkiel Gruppe voted on patch set 2 V +1 CR +1 02/07/20, 09:23

  5. Wolfgang Klinger voted on patch set 2 CR +1 02/07/20, 10:10

  6. Tymoteusz Motylewski voted on patch set 2 CR +1 02/07/20, 18:26

  7. Markus Klein voted on patch set 2 V +1 CR +1 02/07/20, 23:07

  8. Oliver Klee commented on patch set 2 CR -1 02/08/20, 11:58

    SiteListCommand.php:47 Unresolved

    Then these two lines can (and should) be removed.
  9. Georg Ringer uploaded patch set 3 02/08/20, 18:30

  10. Oliver Klee voted on patch set 3 CR +1 02/08/20, 18:37

  11. Markus Klein voted on patch set 3 V +1 CR +1 02/08/20, 18:39

  12. Benni Mack commented on patch set 3 V +2 CR +2 02/09/20, 16:48

    will run the tests locally before merging.
  13. Benni Mack merged patch set 4 02/10/20, 06:10