Review main Merged

63181[FEATURE] Enable recursive transformation of properties in JsonView

Nikita Hovratov CR +2 V +2 Hard +246 −5 updated 08/03/21, 18:38

Commit message

The new property '_recursive' allows to define recursive properties
of objects. These properties are transformed automatically, without
the need to define every entry level manually.

Objects can contain a list of the same type like themselves.
Examples could be folders containing folders or comments having
comments as replies.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2129

Show 4 earlier messages
  1. Nikita Hovratov uploaded patch set 1 02/09/20, 17:36

  2. Nikita Hovratov uploaded patch set 2 02/09/20, 20:49

  3. Anja Leichsenring rebased onto patch set 3 02/13/20, 09:34

  4. Anja Leichsenring commented on patch set 3 CR -1 02/13/20, 09:35

    we need a documentation .rst file here that explains the impact and usage of the new feature. Please find further information and help here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html https://forger.typo3.com/utilities/rst
  1. TYPO3com voted on patch set 3 V -1 02/13/20, 09:39 Completed build in 21s on Thu, 13 Feb, 09:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32

  2. Anja Leichsenring uploaded patch set 4 02/13/20, 09:41

  3. Anja Leichsenring commented on patch set 4 CR -1 02/13/20, 09:45

    we need a documentation .rst file here that explains the impact and usage of the new feature. Please find further information and help here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html https://forger.typo3.com/utilities/rst
  4. TYPO3com voted on patch set 4 V +1 02/13/20, 10:00 Completed build in 15m 53s on Thu, 13 Feb, 10:00 AM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34

  5. Nikita Hovratov uploaded patch set 5 02/13/20, 18:54

  6. TYPO3com voted on patch set 5 V +1 02/13/20, 19:07 Completed build in 12m 47s on Thu, 13 Feb, 07:07 PM Test Summary: 71274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-55

  7. Andreas Kienast commented on patch set 6 02/22/20, 18:11

    Published edit on patch set 5.
  8. TYPO3com voted on patch set 6 V +1 02/22/20, 18:43 Completed build in 28m 33s on Sat, 22 Feb, 06:43 PM Test Summary: 71592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-498

  9. Alexander Schnitzler wrote 03/01/20, 11:18

    Topic set to extbase
  10. Nikita Hovratov uploaded patch set 7 09/02/20, 12:17

  11. TYPO3com voted on patch set 7 V +1 09/02/20, 12:29 Completed build in 11m 42s on Wed, 2 Sep, 12:29 PM Test Summary: 73176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5140

  12. Anja Leichsenring uploaded patch set 8 09/02/20, 19:04

  13. TYPO3com voted on patch set 8 V +1 09/02/20, 19:20 Completed build in 15m 13s on Wed, 2 Sep, 07:20 PM Test Summary: 73194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5153

  14. Benni Mack voted on patch set 8 CR +1 06/14/21, 10:58

  15. Anja Leichsenring rebased onto patch set 9 08/03/21, 16:25

  16. core-ci voted on patch set 9 V +1 08/03/21, 16:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14053

  17. Anja Leichsenring voted on patch set 9 V +1 CR +1 08/03/21, 17:04

  18. Andreas Kienast commented on patch set 9 CR -1 08/03/21, 17:36

    on it
  19. Andreas Kienast uploaded patch set 10 08/03/21, 17:38

  20. Andreas Kienast voted on patch set 10 V +1 CR +1 08/03/21, 17:39

  21. Nikita Hovratov commented on patch set 10 08/03/21, 17:41

    Thanks all! Didn't think this feature would see the sunlight anytime soon :)
  22. Anja Leichsenring voted on patch set 10 V +1 CR +1 08/03/21, 17:41

  23. core-ci voted on patch set 10 V +1 08/03/21, 17:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14056

  24. Anja Leichsenring voted on patch set 10 V +2 CR +2 08/03/21, 18:09

  25. Anja Leichsenring merged patch set 11 08/03/21, 18:38