63183[FEATURE] Implement SameSite option for TYPO3 cookies
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/LoginController.php+17 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+36 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+14 −0
- typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-90351-ConfigureTYPO3-shippedCookiesWithSameSiteFlag.rstnew+60 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/install/Classes/Service/SessionService.php+40 −0
- composer.json+1 −0
- composer.lock+56 −56
Review log 1417
-
Benni Mack uploaded patch set 1 02/10/20, 06:51
-
Benni Mack uploaded patch set 2 02/10/20, 20:48
-
Benni Mack uploaded patch set 3 02/10/20, 21:12
-
Benni Mack updated the commit message in patch set 4 02/11/20, 07:34
-
Benni Mack uploaded patch set 5 02/12/20, 20:29
-
Benni Mack uploaded patch set 6 02/12/20, 20:45
-
TYPO3com voted on patch set 6 V -1 02/12/20, 20:59 Completed build in 13m 32s on Wed, 12 Feb, 08:59 PM Test Summary: 1 of 71713 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17
-
Frank Nägler uploaded patch set 7 02/12/20, 21:43
-
TYPO3com voted on patch set 7 V +1 02/12/20, 21:56 Completed build in 13m 03s on Wed, 12 Feb, 09:56 PM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19
-
Frank Nägler voted on patch set 7 CR +1 02/13/20, 07:42
-
Benni Mack uploaded patch set 8 02/13/20, 09:13
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 02/13/20, 09:20
-
TYPO3com voted on patch set 8 V +1 02/13/20, 09:26 Completed build in 13m 06s on Thu, 13 Feb, 09:26 AM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29
-
Georg Ringer voted on patch set 8 V +2 CR +2 02/13/20, 09:36
-
Georg Ringer merged patch set 9 02/13/20, 09:36
-
Oliver Hader commented on patch set 9 02/13/20, 10:35
WorkspacePreview::setCookie() is missing... -
Susi Moog commented on patch set 9 02/16/20, 12:21
the 9.5 version also got an update on fallback for PHP < 7.3