Review main Merged

63185[BUGFIX] Check correctly for existing click event

Andreas Kienast CR +2 V +2 Easy +5 −2 updated 02/10/20, 08:52

Commit message

With #90238 the JavaScript function `goToalt_doc` is registered as a
Fluid variable. However, the check for an existing event in the template
broke as the variable now always has a value.

To fix the situation, a new boolean variable `hasClickEvent` is
introduced.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Claus Due +1
    • Daniel Goerz +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1

Issues 2

Files 2

Review log 8

  1. Andreas Kienast uploaded patch set 1 02/10/20, 08:30

  2. Daniel Goerz voted on patch set 1 CR +1 02/10/20, 08:41

  3. Claus Due commented on patch set 1 02/10/20, 08:42

    Should also target 9.5 since this was backported to there.
  4. Claus Due updated the commit message in patch set 2 02/10/20, 08:42

  5. Claus Due voted on patch set 2 CR +1 02/10/20, 08:42

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 02/10/20, 08:47

  7. Richard Haeser voted on patch set 2 V +2 CR +2 02/10/20, 08:52

  8. Richard Haeser merged patch set 3 02/10/20, 08:52