Review main Merged

63186[FEATURE] Fluid-based replacement for PageLayoutView

Claus Due CR +2 V +2 Nightmare +2648 −81 updated 03/26/20, 09:18

Commit message

Provides a completely rewritten alternative to PageLayoutView
based on Fluid, and deprecates the old PageLayoutView. Adds
a feature flag TYPO3_CONF_VARS.SYS.features.fluidBasedPageModule
which can be used to switch back to the deprecated
PageLayoutView for installations which require this. The feature
flag is enabled by default in all new installations.

See included feature RST for more detailed information.

Review

  • Code review CR +2 Done
    • Claus Due +2
    • Georg Ringer +1
    • Kevin Appelt +1
    • Manuel Selbach +1
  • Verified V +2 Done
    • Claus Due +2
    • Georg Ringer +1
    • Kevin Appelt +1
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 101149

Show 80124 earlier messages
  1. Claus Due uploaded patch set 1 02/10/20, 08:55

  2. Claus Due uploaded patch set 2 02/11/20, 13:31

  3. Claus Due uploaded patch set 3 02/11/20, 13:53

  4. Claus Due uploaded patch set 4 02/12/20, 08:23

  5. Claus Due uploaded patch set 5 02/15/20, 19:38

  6. TYPO3com voted on patch set 5 V -1 02/15/20, 19:51 Completed build in 06m 23s on Sat, 15 Feb, 07:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-143

  7. Georg Ringer commented on patch set 5 02/15/20, 19:59

    BackendLayout.php:253

    not needed, also below

    ContentFetcher.php:2

    declare_strict for all new files

    ContentFetcher.php:315

    : LanguageService

    Grid.php:2

    copyright missing

    AbstractDrawer.php:134

    return types, also below
  8. Claus Due commented on patch set 5 02/15/20, 20:08

    All line comments addressed, will be part of next PS push. Thanks Georg!

    BackendLayout.php:253 Reply

    Done

    ContentFetcher.php:2 Reply

    Done

    ContentFetcher.php:315 Reply

    Done

    AbstractDrawer.php:134 Reply

    Done
  9. Claus Due uploaded patch set 6 02/15/20, 22:57

  10. TYPO3com voted on patch set 6 V -1 02/15/20, 22:58 Completed build in 22s on Sat, 15 Feb, 10:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-156

  11. Claus Due uploaded patch set 7 02/15/20, 22:59

  12. TYPO3com voted on patch set 7 V -1 02/15/20, 23:13 Completed build in 14m 36s on Sat, 15 Feb, 11:13 PM Test Summary: 6 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-157

  13. TYPO3com commented on patch set 7 02/16/20, 15:32 Completed build in 26m 33s on Sun, 16 Feb, 03:32 PM Test Summary: 6 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-174

  14. Claus Due uploaded patch set 8 02/16/20, 16:15

  15. TYPO3com voted on patch set 8 V -1 02/16/20, 16:15 Completed build in 23s on Sun, 16 Feb, 04:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-177

  16. Claus Due uploaded patch set 9 02/16/20, 16:21

  17. Claus Due uploaded patch set 10 02/16/20, 16:27

  18. TYPO3com voted on patch set 9 V -1 02/16/20, 16:35 Completed build in 13m 38s on Sun, 16 Feb, 04:35 PM Test Summary: 12 of 71434 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-178

  19. TYPO3com voted on patch set 10 V -1 02/16/20, 17:01 Completed build in 25m 44s on Sun, 16 Feb, 05:01 PM Test Summary: 12 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-179

  20. Georg Ringer commented on patch set 10 02/16/20, 19:34

    some differences I have seen (Screenshots in slack) - now in language mode the backend layout is shown, previously it was just 1 list. imo that is better - space after the language name is now gone - at bottom there is a 2nd gray line - buttons in content element are no button group anymore

    PageLayoutController.php:614

    missing implementation

    ContentFetcher.php:209

    remove comments, also below. those don't helü

    Grid.php:19

    missing class description

    GridColumn.php:24

    missing class description

    GridColumnItem.php:29

    missing class description

    GridRow.php:19

    missing class rescription

    LanguageColumn.php:27

    missing class description

    RecordRememberer.php:21

    missing class description

    AbstractDrawer.php:83

    IMO those comments should cleaned up as well

    DrawingConfiguration.php:33

    class descr.

    PageLayoutDrawer.php:25

    class desc.
  21. Georg Ringer voted on patch set 10 V -1 02/16/20, 19:34

  22. Claus Due uploaded patch set 11 02/16/20, 23:11

  23. TYPO3com voted on patch set 11 V -1 02/16/20, 23:31 Completed build in 47s on Sun, 16 Feb, 11:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-185

  24. Georg Ringer commented on patch set 11 02/17/20, 07:35

    PageLayoutController.php:614

    please use the real feature flag features we have

    ContentFetcher.php:215

    comments still not useful, also below
  25. Georg Ringer voted on patch set 11 CR -1 02/17/20, 07:35

  26. Claus Due uploaded patch set 12 02/17/20, 09:49

  27. Claus Due commented on patch set 11 02/17/20, 09:49

    I've removed some redundant comments and elaborated others. See below for Q about feature flag.

    PageLayoutController.php:614 Reply

    Can you elaborate? I did a cursory check and found only feature flagging API that was internal to EXT:install which is not recorded as dependency of this extension.
  28. TYPO3com voted on patch set 12 V -1 02/17/20, 09:49 Completed build in 25s on Mon, 17 Feb, 09:49 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-193

  29. Georg Ringer commented on patch set 12 02/17/20, 12:57

    PageLayoutController.php:614 Reply

    yes that is the one
  30. Claus Due uploaded patch set 13 02/17/20, 13:43

  31. TYPO3com voted on patch set 13 V -1 02/17/20, 13:43 Completed build in 23s on Mon, 17 Feb, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-202

  32. Claus Due uploaded patch set 14 02/17/20, 13:49

  33. Claus Due uploaded patch set 15 02/17/20, 13:49

  34. TYPO3com voted on patch set 15 V -1 02/17/20, 13:50 Completed build in 25s on Mon, 17 Feb, 01:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-205

  35. Claus Due uploaded patch set 16 02/17/20, 13:58

  36. TYPO3com voted on patch set 14 V -1 02/17/20, 14:02 Completed build in 12m 57s on Mon, 17 Feb, 02:02 PM Test Summary: 12 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-203

  37. TYPO3com voted on patch set 16 V -1 02/17/20, 14:11 Completed build in 13m 06s on Mon, 17 Feb, 02:11 PM Test Summary: 12 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-207

  38. Claus Due commented on patch set 16 02/17/20, 14:13

    I'm not sure how to fix the single failing test; tips would be welcome. It's caused by TS parsing now occuring whenever BackendLayout->setConfiguration() is called, which: 1. cascades to using the ConditionMatcher 2. which calls initializeExpressionLanguageResolver() 3. which in turn wants to create an instance of \TYPO3\CMS\Core\ExpressionLanguage\Resolver 4. which uses the \TYPO3\CMS\Core\ExpressionLanguage\ProviderConfigurationLoader The ProviderConfigurationLoader is the class that internally tries to instance PackageManager but is unable to do so due to dependency injection.
  39. Claus Due commented on patch set 16 02/17/20, 14:23

    FYI: I could circumvent the TS parsing trigger by adapting the test to pass an array instead of a string, but I'm not sure that's good to do...
  40. Claus Due uploaded patch set 17 02/17/20, 15:27

  41. TYPO3com voted on patch set 17 V -1 02/17/20, 15:42 Completed build in 15m 06s on Mon, 17 Feb, 03:42 PM Test Summary: 12 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-211

  42. Kay Strobach commented on patch set 17 02/17/20, 18:58

    PageLayout.html:12

    please move that into a partial
  43. Claus Due commented on patch set 17 02/17/20, 19:03

    PageLayout.html:12 Reply

    Yep, good idea, will do!
  44. Claus Due uploaded patch set 18 02/17/20, 20:22

  45. TYPO3com voted on patch set 18 V -1 02/17/20, 20:51 Completed build in 21m 30s on Mon, 17 Feb, 08:51 PM Test Summary: 12 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-222

  46. Claus Due uploaded patch set 19 02/17/20, 21:01

  47. TYPO3com voted on patch set 19 V -1 02/17/20, 21:23 Completed build in 17m 07s on Mon, 17 Feb, 09:23 PM Test Summary: 6 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-226

  48. Claus Due uploaded patch set 20 02/17/20, 22:15

  49. TYPO3com voted on patch set 20 V -1 02/17/20, 22:16 Completed build in 25s on Mon, 17 Feb, 10:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-229

  50. Claus Due uploaded patch set 21 02/17/20, 22:17

  51. Claus Due uploaded patch set 22 02/17/20, 22:23

  52. Claus Due uploaded patch set 23 02/17/20, 22:29

  53. TYPO3com voted on patch set 21 V -1 02/17/20, 22:38 Completed build in 16m 40s on Mon, 17 Feb, 10:38 PM Test Summary: 71332 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-230

  54. TYPO3com voted on patch set 22 V -1 02/17/20, 22:58 Completed build in 23m 50s on Mon, 17 Feb, 10:58 PM Test Summary: 71331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-232

  55. TYPO3com voted on patch set 23 V -1 02/17/20, 23:11 Completed build in 36m 37s on Mon, 17 Feb, 11:11 PM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-233

  56. Claus Due uploaded patch set 24 02/18/20, 09:55

  57. Claus Due uploaded patch set 25 02/18/20, 10:00

  58. TYPO3com commented on patch set 23 02/18/20, 10:04 Completed build in 13m 51s on Tue, 18 Feb, 10:04 AM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-239

  59. TYPO3com voted on patch set 24 V -1 02/18/20, 10:11 Completed build in 15m 47s on Tue, 18 Feb, 10:11 AM Test Summary: 71336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-240

  60. TYPO3com voted on patch set 25 V +1 02/18/20, 10:16 Completed build in 15m 07s on Tue, 18 Feb, 10:16 AM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-241

  61. Benni Mack commented on patch set 25 02/19/20, 08:58

    Can you explain the "Drawer" concept? I guess this would be new for people looking at that code.

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:79

    you RST still states the "old" option (not the feature flag), I recommend explaining to enable this option via the Settings module in the Maintenance area (= making it easier for people to enable it)
  62. Claus Due commented on patch set 25 02/19/20, 09:16

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:79 Reply

    Right, Benni - I will change this right away!
  63. Claus Due commented on patch set 25 02/19/20, 09:20

    > Can you explain the "Drawer" concept? I guess this would be new for people looking at that code. Of course. The "drawer" (there's only one of those) is essentially the replacement for the PageLayoutView - it's the class responsible for initiating the drawing of a page backend layout, by creating a Fluid view and assigning the necessary variables to it. Custom subclasses of BackendLayout could theoretically change this class to use a custom "drawer" which assigns more variables or uses a custom Fluid View class, for example. The "drawer" also contains some functions that render the paste icon, since this could not be rendered from within the Fluid template (creates JS attached to PageRenderer) and it is responsible for initializing the clipboard of the current user (clipboard init causes insertion of paste icons through JS if there are items in the clipboard).
  64. Claus Due uploaded patch set 26 02/19/20, 09:28

  65. TYPO3com voted on patch set 26 V +1 02/19/20, 09:42 Completed build in 13m 17s on Wed, 19 Feb, 09:42 AM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-293

  66. Benni Mack commented on patch set 26 02/19/20, 13:05

    > Patch Set 25: > > > Can you explain the "Drawer" concept? I guess this would be new for people looking at that code. > > Of course. The "drawer" (there's only one of those) is essentially the replacement for the PageLayoutView - it's the class responsible for initiating the drawing of a page backend layout, by creating a Fluid view and assigning the necessary variables to it. > > Custom subclasses of BackendLayout could theoretically change this class to use a custom "drawer" which assigns more variables or uses a custom Fluid View class, for example. > > The "drawer" also contains some functions that render the paste icon, since this could not be rendered from within the Fluid template (creates JS attached to PageRenderer) and it is responsible for initializing the clipboard of the current user (clipboard init causes insertion of paste icons through JS if there are items in the clipboard). LOL. Got it I thought of a drawer as in https://www.google.com/search?q=drawer&safe=strict&source=lnms&tbm=isch&sa=X you know - a drawer ;). Would it be OK if we rename it to "PageModuleRenderer", "PageModuleContentRenderer" or something like this? Reasoning: I try to get rid of the name "PageLayout" - if we bind it to the actual Page Module (this is how it is named in all of the docs) it will make it easier to understand for new people to see what should be related to the page module directly. Of course, you can imagine I hate the name "PageLayoutController" as well ;)
  67. Georg Ringer commented on patch set 26 CR -1 02/19/20, 13:06

    - the edit column button does'nt work - the edit column button must only be shown if there are elements in the column
  68. Claus Due commented on patch set 26 02/19/20, 13:10

    > LOL. Got it I thought of a drawer as in https://www.google.com/search?q=drawer&safe=strict&source=lnms&tbm=isch&sa=X > > you know - a drawer ;). > > Would it be OK if we rename it to "PageModuleRenderer", "PageModuleContentRenderer" or something like this? Reasoning: I try to get rid of the name "PageLayout" - if we bind it to the actual Page Module (this is how it is named in all of the docs) it will make it easier to understand for new people to see what should be related to the page module directly. > > Of course, you can imagine I hate the name "PageLayoutController" as well ;) Hehe okay not that type of drawer ^^ Sure, I can rename that. How does BackendLayoutRenderer sound? It isn't exactly responsible for rendering the entire module, only the grid part of it. And it gets returned from BackendLayout as the API for rendering a BackendLayout in BE. PS: it isn't restricted to being used in the page layout module. That's just the only place it is currently used!
  69. Georg Ringer commented on patch set 26 02/19/20, 13:10

    - in columns mode, the language icon at content elements is gone - tn language mode the layout is broken, screenshot in slack
  70. Claus Due uploaded patch set 27 02/19/20, 13:21

  71. TYPO3com voted on patch set 27 V -1 02/19/20, 13:22 Completed build in 33s on Wed, 19 Feb, 01:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-299

  72. Claus Due uploaded patch set 28 02/19/20, 13:23

  73. TYPO3com voted on patch set 28 V -1 02/19/20, 13:24 Completed build in 25s on Wed, 19 Feb, 01:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-300

  74. Claus Due uploaded patch set 29 02/19/20, 13:24

  75. TYPO3com voted on patch set 29 V -1 02/19/20, 13:38 Completed build in 13m 24s on Wed, 19 Feb, 01:38 PM Test Summary: 2 of 71493 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-301

  76. Georg Ringer commented on patch set 29 02/19/20, 13:40

    Call to undefined method TYPO3\CMS\Backend\View\BackendLayout\BackendLayout::getPageLayoutDrawer() in /app/web/typo3/sysext/backend/Classes/Controller/PageLayoutController.php line 637
  77. Claus Due uploaded patch set 30 02/19/20, 13:40

  78. Claus Due uploaded patch set 31 02/19/20, 13:48

  79. Georg Ringer commented on patch set 31 02/19/20, 13:50

    Show hidden content elements doesn't work
  80. TYPO3com voted on patch set 30 V +1 02/19/20, 13:59 Completed build in 15m 58s on Wed, 19 Feb, 01:59 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-303

  81. Claus Due uploaded patch set 32 02/19/20, 14:04

  82. TYPO3com voted on patch set 31 V -1 02/19/20, 14:16 Completed build in 26m 11s on Wed, 19 Feb, 02:16 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-305

  83. TYPO3com voted on patch set 32 V -1 02/19/20, 14:19 Completed build in 15m 27s on Wed, 19 Feb, 02:19 PM Test Summary: 70750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-306

  84. Claus Due uploaded patch set 33 02/19/20, 14:22

  85. Claus Due uploaded patch set 34 02/19/20, 14:29

  86. TYPO3com voted on patch set 33 V -1 02/19/20, 14:36 Completed build in 13m 26s on Wed, 19 Feb, 02:36 PM Test Summary: 2 of 71800 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-307

  87. TYPO3com voted on patch set 34 V +1 02/19/20, 14:43 Completed build in 14m 07s on Wed, 19 Feb, 02:43 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-308

  88. Georg Ringer voted on patch set 34 V +1 CR +1 02/19/20, 14:44

  89. Claus Due uploaded patch set 35 02/19/20, 14:54

  90. TYPO3com voted on patch set 35 V +1 02/19/20, 15:09 Completed build in 14m 13s on Wed, 19 Feb, 03:09 PM Test Summary: 71342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-310

  91. Georg Ringer voted on patch set 35 V +1 CR +1 02/19/20, 17:03

  92. Claus Due uploaded patch set 36 02/20/20, 12:07

  93. TYPO3com voted on patch set 36 V -1 02/20/20, 12:08 Completed build in 27s on Thu, 20 Feb, 12:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-339

  94. Claus Due uploaded patch set 37 02/20/20, 12:17

  95. TYPO3com voted on patch set 37 V +1 02/20/20, 12:36 Completed build in 18m 36s on Thu, 20 Feb, 12:36 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-340

  96. Claus Due uploaded patch set 38 02/20/20, 12:40

  97. Claus Due commented on patch set 38 02/20/20, 12:46

    Found and fixed a couple of issues: * Unused content might be incorrectly reported when "languages" view was used, now only reports unused content in relevant language. * "Languages" view with default language selected did not show all language columns. And made a minor change to prevent potential issues with "additionalConstraints" for QueryBuilder: * Removed $fields and $additionalConstraints from getQueryBuilder method signature to prevent potential issues with constraints that use named query parameters but were generated using a foreign instance of QueryBuilder. Additional constraints can now only be added *after* the right QueryBuilder instance is returned. The two arguments were a leftover from PageLayoutView and isn't required in the new ContentFetcher.
  98. TYPO3com voted on patch set 38 V +1 02/20/20, 13:32 Completed build in 27m 57s on Thu, 20 Feb, 01:32 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-341

  99. Claus Due uploaded patch set 39 02/20/20, 15:04

  100. TYPO3com voted on patch set 39 V +1 02/20/20, 15:42 Completed build in 36m 57s on Thu, 20 Feb, 03:42 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-346

  101. Claus Due uploaded patch set 40 02/20/20, 17:02

  102. Claus Due uploaded patch set 41 02/20/20, 17:04

  103. TYPO3com voted on patch set 40 V +1 02/20/20, 17:20 Completed build in 18m 14s on Thu, 20 Feb, 05:20 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-350

  104. TYPO3com voted on patch set 41 V +1 02/20/20, 17:33 Completed build in 20m 33s on Thu, 20 Feb, 05:33 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-351

  105. Claus Due uploaded patch set 42 02/20/20, 18:50

  106. Claus Due commented on patch set 42 02/20/20, 18:52

    Fixed issues in recent pushes: * Language mode reported as "connected mode" for language columns without content * Possible strange behavior for columns with colPos=null
  107. TYPO3com voted on patch set 42 V +1 02/20/20, 19:08 Completed build in 18m 23s on Thu, 20 Feb, 07:08 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-355

  108. Claus Due uploaded patch set 43 02/20/20, 19:17

  109. Claus Due commented on patch set 43 02/20/20, 19:23

    Fixed issues in recent push: * colPos=null gets rendered in columns view precisely like PageLayoutView would do * Translation modal should be able to display content summary evne if colPos=null column is present in layout
  110. Claus Due uploaded patch set 44 02/20/20, 19:31

  111. Claus Due commented on patch set 44 02/20/20, 19:32

    * Fixed issue with backend layout configuration array processing which before this patch, ignored colPos=null except for when rendering grid. Previous behavior now restored.
  112. TYPO3com voted on patch set 43 V +1 02/20/20, 19:52 Completed build in 19m 37s on Thu, 20 Feb, 07:52 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-359

  113. Claus Due uploaded patch set 45 02/20/20, 20:01

  114. Claus Due commented on patch set 45 02/20/20, 20:03

    * Fixed a strange behavior of LocalizationController causing items to be encoded as object if colPos values were not in perfect sequential order.
  115. TYPO3com voted on patch set 44 V +1 02/20/20, 20:13 Completed build in 40m 21s on Thu, 20 Feb, 08:13 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-361

  116. TYPO3com voted on patch set 45 V +1 02/20/20, 20:26 Completed build in 20m 41s on Thu, 20 Feb, 08:26 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-362

  117. Kevin Appelt commented on patch set 45 V +1 CR +1 02/20/20, 20:27

    After a lot of edge case testing and fixing :)
  118. Claus Due uploaded patch set 46 02/20/20, 20:36

  119. TYPO3com voted on patch set 46 V +1 02/20/20, 21:25 Completed build in 38m 39s on Thu, 20 Feb, 09:25 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-364

  120. Kevin Appelt voted on patch set 46 V +1 CR +1 02/20/20, 21:35

  121. Claus Due uploaded patch set 47 02/20/20, 21:51

  122. Claus Due commented on patch set 47 02/20/20, 21:52

    * Fixed issue with workspaces deletion placeholder being visible in grid.
  123. Kevin Appelt voted on patch set 47 V +1 CR +1 02/20/20, 21:54

  124. Georg Ringer voted on patch set 47 V +1 CR +1 02/20/20, 21:57

  1. TYPO3com voted on patch set 47 V -1 02/20/20, 23:19 Completed build in 1h 14m 48s on Thu, 20 Feb, 11:19 PM Test Summary: 2 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-371

  2. TYPO3com commented on patch set 47 02/21/20, 07:50 Completed build in 26m 45s on Fri, 21 Feb, 07:50 AM Test Summary: 2 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-382

  3. Claus Due uploaded patch set 48 02/21/20, 08:08

  4. TYPO3com voted on patch set 48 V +1 02/21/20, 08:50 Completed build in 35m 14s on Fri, 21 Feb, 08:50 AM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-384

  5. Kevin Appelt voted on patch set 48 V +1 CR +1 02/21/20, 09:04

  6. Benni Mack commented on patch set 48 02/21/20, 09:12

    will have time for a more thorough review tonight, if it gets merged before, I'll do that afterwards
  7. Claus Due uploaded patch set 49 02/21/20, 12:32

  8. Claus Due commented on patch set 49 02/21/20, 12:32

    * Fixed column name not translated in "translate" modal record summary
  9. Claus Due commented on patch set 49 02/21/20, 12:53

    PageLayoutController.php:614 Reply

    Done

    PageLayoutController.php:614 Reply

    Done

    ContentFetcher.php:209 Reply

    Done

    ContentFetcher.php:215 Reply

    Done

    Grid.php:2 Reply

    Done

    Grid.php:19 Reply

    Done

    GridColumn.php:24 Reply

    Done

    GridColumnItem.php:29 Reply

    Done

    GridRow.php:19 Reply

    Done

    LanguageColumn.php:27 Reply

    Done

    RecordRememberer.php:21 Reply

    Done

    AbstractDrawer.php:83 Reply

    Done

    DrawingConfiguration.php:33 Reply

    Done

    PageLayoutDrawer.php:25 Reply

    Done

    PageLayout.html:12 Reply

    Done

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:79 Reply

    Done
  10. Kevin Appelt voted on patch set 49 V +1 CR +1 02/21/20, 12:56

  11. TYPO3com voted on patch set 49 V +1 02/21/20, 13:38 Completed build in 29m 44s on Fri, 21 Feb, 01:38 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-396

  12. Georg Ringer voted on patch set 49 V +1 CR +1 02/21/20, 15:35

  13. Manuel Selbach voted on patch set 49 V +1 CR +1 02/21/20, 18:28

  14. Claus Due voted on patch set 49 V +2 CR +2 02/21/20, 18:29

  15. Claus Due merged patch set 50 02/21/20, 18:29

  16. Alexander Schnitzler commented on patch set 50 02/22/20, 10:07

    BackendLayout.php:311 Unresolved

    Post -1: > Access to an undefined property TYPO3\CMS\Backend\View\BackendLayout\BackendLayout::$id

    GridColumnItem.php:198 Unresolved

    Post -1: > Access to an undefined property TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem::$pageinfo
  17. Benni Mack commented on patch set 50 03/22/20, 19:58

    Currently reviewing this change in-depth. A couple of things are really good: - Abstracting the fetching of Content in a separate class "ContentFetcher" - Having objects / entities instead of an array of arrays for the Backend Layout Configuration - Having the configuration of the Page Layout module in a custom Configuration object I see some critical things I would like to address in followup changes: We are now mixing the state of the a) Page Module and b) its configuration based on a concrete page ID in the previous stateless BackendLayout class. This basically makes a BackendLayout very powerful but at the same time like a "Data Hub for the content and the language columns". A backend layout is IMHO independent of Languages and what records are in each column. This should be handled fully separately. The backend layout is like the Configuration information, it separates the definition of the configuration (e.g. PageTS or DB) from the actual definition of the Layout (which is in BackendLayoutView). I guess we would need to shift this logic into a new class or in BackendLayoutView, combining the data / content of the page with the definition of the layout - like a "PageLayoutPopulator" - this one could also keep track of the records in use ("RecordRememberer").
  18. Oliver Hader commented on patch set 50 03/22/20, 20:31

    In general: We should work on the modelling part and really separate concerns for infrastructure (database, repository, ...), model/dto (grid, columns, ...), configuration/permission part (TSconfig, TCA, backend user permission). Maybe it's possible to get rid of inline HTML and JavaScript as well...

    GridColumn.php:82

    Hm... probably we should enhance this structure... GridColumn is the deepest part of the model (backend layout -> grid -> grid row -> grid column)... and here it goes up again to some grand parent to continue. I think we really should separate database/storage from these models...

    DefaultConfiguration.php:75

    What about "backend.fluidBasedPageModule" (partitioned by scope)?

    DefaultConfiguration.php:1078

    Is this the same as the feature-flag above?

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:61

    Does it refer to the TCA ctrl section?

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:80

    Shouldn't that be the feature flag instead?
  19. Claus Due commented on patch set 50 03/23/20, 07:48

    GridColumn.php:82 Reply Unresolved

    At this point, ContentFetcher behaves more like a DTO and won't perform database queries. There is one use case in which it would perform database queries here: if you create an instance of the GridColumn *separately* from the normal grid and do not provide the $records array. I would not begin refactoring to a repository here either, since this opens a very large bag of tangents about "universal content repository" type use cases.

    DefaultConfiguration.php:75 Reply Unresolved

    Would not change this before LTS is released. At that time we could also clean up other (inconsistent) feature flags.

    DefaultConfiguration.php:1078 Reply Unresolved

    Yes; this one should have been removed so only the feature flag remained.

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:61 Reply Unresolved

    No, it is an assertion method that returns false if, for example, the record is locked for editing.

    Feature-90348-NewFluid-basedReplacementForPageLayoutView.rst:80 Reply Unresolved

    Yes, missed this occurrence - it must refer to the feature flag as mentioned above.
  20. Claus Due commented on patch set 50 03/23/20, 08:11

    > I see some critical things I would like to address in followup changes: > We are now mixing the state of the a) Page Module and b) its configuration based on a concrete page ID in the previous stateless BackendLayout class. The way I look at this is slightly different: BackendLayouts are still technically stateless, but allow returning a preconfigured configuration (since the configuration partially depends on the state of the BackendLayout, e.g. which columns it contains). The configuration is not made page-specific until the PageLayoutController starts to render it - and then the state of configuration, not BackendLayout, is mutated. > This basically makes a BackendLayout very powerful but at the same time like a "Data Hub for the content and the language columns". This is completely intentional: we use "DataProviders" that are capable of returning different types of BackendLayouts and "DataProviderCollections" which contain multiple providers and layouts. Because of this, the exchange API is actually the BackendLayout (not the BackendLayoutView or any other class). This is why I made BackendLayout able to return the implementations it might require (renderer, fetcher, configuration). I do personally think that the structure of data providers and provider collections is significantly over-engineered and in many ways redundant. They also have cross-responsibilities with the BackendLayoutView (which btw isn't a "view"). It would IMHO be a mistake and a step backwards to delegate further responsibilities to those classes! > A backend layout is IMHO independent of Languages and what records are in each column. It still is; the content fetcher however is not. As mentioned above, the state of the BackendLayout isn't what changes - it's the state of implementations it returns which changes. BackendLayout in other words is a gateway object that holds a rows/columns definition *and* the implementations required to fetch/render it. > This should be handled fully separately. The backend layout is like the Configuration information, it separates the definition of the configuration (e.g. PageTS or DB) from the axctual definition of the Layout (which is in BackendLayoutView). As mentioned above, I see BackendLayoutView as a problem that I'd rather get rid of, than give more responsibilities. > I guess we would need to shift this logic into a new class or in BackendLayoutView, combining the data / content of the page with the definition of the layout - like a "PageLayoutPopulator" - this one could also keep track of the records in use ("RecordRememberer"). I think we could find a way here, but: * I certainly would not use BackendLayoutView; instead I would aim to delete BackendLayoutView. * More importantly, I wouldn't start doing this before LTS release! The implementation in 10.3 exists to provide a smooth transition from early adopters' implementations to LTS implementations and we would be counteracting that by performing such refactoring before LTS release. The second item above is also why I chose to not start the removal of BackendLayoutView, BackendLayoutDataProvider and BackendLayoutDataProviderCollection - doing that would make the implementation incompatible and require a significant effort from users who used these features. I definitely see this as something to look at after LTS release, when we are free to make drastic breaking changes.
  21. Claus Due commented on patch set 50 03/23/20, 08:27

    Oh, and I should also mention: the proposed plan for "content grids" aims in the final iteration to deprecate the entirity of BackendLayoutView, BackendLayoutDataProvider and BackendLayoutDataProviderCollection. Possibly converting BackendLayout to a mutable replacement ("content grids" would be dynamic but BackendLayout is still a nice "inbetween" type of class to present and exchange persisted row/column structures). Perhaps we can focus our efforts in "content grids" instead of refactoring the current implementations? Seeing as if/when the "content grids" plan is approved and set in motion, refactoring of these implementations would be quite redundant.
  22. Benni Mack commented on patch set 50 03/25/20, 15:59

    BackendLayoutView.php:356

    small issues here: the change here is bad for two reasons: a) the cache (see line 388) is not populated anymore, thus, making line 338 obsolete. b) not running via the TypoScript Parser at this point will not be evaluated, thus, any changes to the rows based on PageTS conditions will not be evaluated at this point anymore (whether this is good practice or not is another reason)
  23. Claus Due commented on patch set 50 03/26/20, 08:59

    BackendLayoutView.php:338 Unresolved

    Cache is consulted here

    BackendLayoutView.php:356 Reply Unresolved

    I've added comments elsewhere to address item (a). Regarding item (b) the behavior should match the behavior that existed before, because the result was also cached before. Conditions will only be evaluated once per request, that's true, but this is the same as it was before.

    BackendLayoutView.php:388

    Cache is populated here
  24. Benni Mack commented on patch set 50 03/26/20, 09:11

    BackendLayoutView.php:388 Reply

    Yes. But the population is removed :) But the upper part isn't... see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918
  25. Claus Due commented on patch set 50 03/26/20, 09:18

    BackendLayoutView.php:388 Reply Unresolved

    Ah now I got your point. You are correct!