Review main Merged

63204[BUGFIX] Make abstract test class really abstract to exclude it from test runs

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 02/12/20, 05:23

Commit message

Added the missing keyword abstract to the class definition to prevent
phpunit from issuing a warning about the class not containing any tests.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2

Issues 1

Files 1

Review log 7

  1. Anja Leichsenring uploaded patch set 1 02/11/20, 16:33

  2. Anja Leichsenring uploaded patch set 2 02/11/20, 16:39

  3. Anja Leichsenring uploaded patch set 3 02/11/20, 16:47

  4. Oliver Klee voted on patch set 3 CR +1 02/11/20, 16:51

  5. Oliver Hader voted on patch set 3 CR +1 02/11/20, 18:48

  6. Georg Ringer voted on patch set 3 V +2 CR +2 02/12/20, 05:23

  7. Georg Ringer merged patch set 4 02/12/20, 05:23