Review main Merged

63211[TASK] Remove unused code in New CE Wizard / PagePositionMap

Benni Mack CR +2 V +2 Hard +100 −158 updated 02/13/20, 08:34

Commit message

There are a few places where unused options can be simplified,
and the dependency on the PagePositionMap class can be placed in
one dedicated method.

Several guard clauses are useless due to method parameter types,
and are cleaned up.

This is a pre-patch to bring more functionality into New Content
Element Wizard.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Benni Mack uploaded patch set 1 02/12/20, 21:13

  2. TYPO3com voted on patch set 1 V +1 02/12/20, 21:36 Completed build in 22m 21s on Wed, 12 Feb, 09:36 PM Test Summary: 71261 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18

  3. Wouter Wolters voted on patch set 1 CR +1 02/12/20, 22:03

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/13/20, 04:18

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/13/20, 08:34

  6. Anja Leichsenring merged patch set 2 02/13/20, 08:34