63214[FEATURE] Implement SameSite option for TYPO3 cookies
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/LoginController.php+17 −4
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+23 −1
- typo3/sysext/core/Classes/Http/CookieHeaderTrait.phpnew+74 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+14 −0
- typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-90351-ConfigureTYPO3-shippedCookiesWithSameSiteFlag.rstnew+60 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/install/Classes/Service/SessionService.php+13 −0
- typo3/sysext/rsaauth/Classes/Storage/SplitStorage.php+16 −2
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+22 −1
- composer.json+1 −0
- composer.lock+118 −1
Review log 1725
-
Benni Mack commented on patch set 1 02/13/20, 09:41
Cherry Picked from branch master. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/backend/Classes/Controller/LoginController.php * typo3/sysext/core/Configuration/DefaultConfiguration.php * typo3/sysext/core/composer.json -
TYPO3com voted on patch set 1 V -1 02/13/20, 09:45 Completed build in 29s on Thu, 13 Feb, 09:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-10
-
Benni Mack uploaded patch set 2 02/13/20, 09:48
-
Benni Mack commented on patch set 2 02/13/20, 09:48
This change is ready for review. -
Benni Mack uploaded patch set 3 02/13/20, 09:51
-
TYPO3com voted on patch set 2 V +1 02/13/20, 10:10 Completed build in 19m 05s on Thu, 13 Feb, 10:10 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-11
-
TYPO3com voted on patch set 3 V +1 02/13/20, 10:16 Completed build in 25m 03s on Thu, 13 Feb, 10:16 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-12
-
Oliver Hader commented on patch set 3 CR -1 02/13/20, 10:34
There are a couple of more things to consider prior to TYPO3 v10: * LoginController is calling session_start() - which probably can be removed * ext:rsaauth is calling session_start() as well for custom PKI management * ext:rsaauth is using old setcookie() method - see SplitStorage * ext:workspaces is using old setcookie() method - see WorkspacePreview::setCookie() -
Oliver Hader uploaded patch set 4 02/13/20, 14:33
-
TYPO3com voted on patch set 4 V +1 02/13/20, 14:45 Completed build in 11m 54s on Thu, 13 Feb, 02:45 PM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-13
-
Benni Mack voted on patch set 4 CR +1 02/13/20, 15:37
-
Susi Moog voted on patch set 4 CR +1 02/14/20, 15:20
-
Oliver Hader voted on patch set 4 CR -1 02/15/20, 12:51
-
Oliver Hader uploaded patch set 5 02/15/20, 12:57
-
Oliver Hader voted on patch set 5 CR +1 02/15/20, 12:59
-
TYPO3com voted on patch set 5 V -1 02/15/20, 13:10 Completed build in 12m 18s on Sat, 15 Feb, 01:10 PM Test Summary: 1 of 74927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-32
-
TYPO3com voted on patch set 5 V +1 02/15/20, 13:52 Completed build in 1h 07m 01s on Sat, 15 Feb, 01:52 PM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-32
-
Susi Moog commented on patch set 5 V -1 02/16/20, 12:06
the resend method fails in versions below < 7.3 at least for the install tool. trying to figure out why. -
Susi Moog uploaded patch set 6 02/16/20, 12:16
-
Susi Moog commented on patch set 6 02/16/20, 12:20
> Patch Set 5: Verified-1 > > the resend method fails in versions below < 7.3 at least for the install tool. trying to figure out why. Fixed now for PHP < 7.3 - regenerate_id sends new cookies that weren't getting the property (as renewSession is basically called all the time overwriting the existing cookies) -
TYPO3com voted on patch set 6 V -1 02/16/20, 12:45 Completed build in 23m 20s on Sun, 16 Feb, 12:45 PM Test Summary: 72814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-36
-
TYPO3com voted on patch set 6 V +1 02/16/20, 13:55 Completed build in 1h 56m 39s on Sun, 16 Feb, 01:55 PM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-36
-
Susi Moog voted on patch set 6 V +1 CR +1 02/16/20, 16:44
-
Georg Ringer voted on patch set 6 V +2 CR +2 02/16/20, 19:36
-
Georg Ringer merged patch set 7 02/16/20, 19:36