63215[FEATURE] Implement SameSite option for TYPO3 cookies
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Georg Ringer +1
- Susi Moog +1
-
Verified V +2 Done
- Richard Haeser +2
- Georg Ringer +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/LoginController.php3+14 −3
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+24 −1
- typo3/sysext/core/Classes/Http/CookieHeaderTrait.phpnew+75 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.php+2 −0
- typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-90351-ConfigureTYPO3-shippedCookiesWithSameSiteFlag.rstnew+60 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/install/Classes/Service/SessionService.php+13 −0
- typo3/sysext/rsaauth/Classes/Storage/SplitStorage.php+16 −2
- typo3/sysext/workspaces/Classes/Hook/PreviewHook.php+22 −1
- composer.json+1 −0
- composer.lock+160 −105
Review log 1621
-
Benni Mack commented on patch set 1 02/13/20, 09:52
Cherry Picked from branch 9.5. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/backend/Classes/Controller/LoginController.php * typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php * typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml * typo3/sysext/core/composer.json * typo3/sysext/install/Classes/Service/SessionService.php -
Benni Mack uploaded patch set 2 02/13/20, 10:05
-
Benni Mack commented on patch set 2 02/13/20, 10:05
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 02/13/20, 10:10 Completed build in 01m 01s on Thu, 13 Feb, 10:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-5
-
TYPO3com voted on patch set 2 V -1 02/13/20, 10:22 Completed build in 13m 00s on Thu, 13 Feb, 10:22 AM Test Summary: 3 of 102478 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-6
-
Oliver Hader commented on patch set 2 CR -1 02/13/20, 10:36
Potentially incomplete, see changeset in 9.5 branch -
Oliver Hader uploaded patch set 3 02/15/20, 14:17
-
Oliver Hader commented on patch set 3 CR -1 02/15/20, 14:18
Streamline now with 9.5 patch... For whatever reason I was not able to execute `composer install` due to a couple of conflicts (currently sitting in a train, probably bad internet connection on resolving packages might be one reason here). -
TYPO3com voted on patch set 3 V -1 02/15/20, 14:28 Completed build in 10m 56s on Sat, 15 Feb, 02:28 PM Test Summary: 6 of 102478 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-9
-
Oliver Hader uploaded patch set 4 02/17/20, 12:27
-
Susi Moog voted on patch set 4 CR +1 02/17/20, 12:32
-
Oliver Hader uploaded patch set 5 02/17/20, 12:35
-
TYPO3com voted on patch set 4 V +1 02/17/20, 12:38 Completed build in 10m 24s on Mon, 17 Feb, 12:38 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-10
-
TYPO3com voted on patch set 5 V +1 02/17/20, 12:50 Completed build in 11m 38s on Mon, 17 Feb, 12:50 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-11
-
Susi Moog commented on patch set 5 V +1 CR +1 02/17/20, 13:01
Tested with PHP 7.3 and 7.2 -
Georg Ringer voted on patch set 5 V +1 CR +1 02/17/20, 15:35
-
Richard Haeser voted on patch set 5 V +2 CR +2 02/17/20, 21:28
-
Richard Haeser merged patch set 6 02/17/20, 21:28
-
Jan Stockfisch commented on patch set 6 03/09/20, 16:16
LoginController.php:95Isn't this a regression? (We were forced to adjust our LoginProviders) -
Oliver Hader commented on patch set 6 03/09/20, 19:08
LoginController.php:95ReplyWhy? -
Jan Stockfisch commented on patch set 6 03/10/20, 09:11
LoginController.php:95Reply UnresolvedWe extended our password rules by quit a bit using LoginProviders. For example a password expires after a certain amount of days. When this happens there is no BE authentication available, because the user has not been authenticated. We use $_SESSION for some session specific redirection to the password reset form and other stuff. This workflow broke, because there was no PHP session started. This is something we had to react to and implement it ourselves. Not a big deal for us, but for some it might.