Review 9.5 Merged

63219[TASK] Access VH VariableContainer through RenderingContext

Georg Ringer CR +2 V +2 Normal +67 −51 updated 02/17/20, 18:43

Commit message

Changes access of $this->viewHelperVariableContainer to
$this->renderingContext->getViewHelperVariableContainer
since the former is deprecated in AbstractViewHelper.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 45

  1. Georg Ringer commented on patch set 1 02/14/20, 19:52

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/14/20, 20:11 Completed build in 18m 46s on Fri, 14 Feb, 08:11 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-19

  3. Claus Due commented on patch set 1 02/17/20, 14:22

    Is this backport ready for merging or do we need a round of testing?
  4. Georg Ringer voted on patch set 1 V +2 CR +2 02/17/20, 18:43

  5. Georg Ringer merged patch set 2 02/17/20, 18:43