Review 9.5 Merged

63221[BUGFIX] Make user avatar buttons accessible via keyboard

Benni Mack CR +2 V +2 Easy +5 −4 updated 02/15/20, 09:20

Commit message

Both "clear" and "add" buttons for the backend user avatar selection
are currently not accessible via keyboard. In order to solve this
accessibility issue, both buttons have been converted from links to
html buttons to trigger the onclick handler when using the keyboard.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Benni Mack commented on patch set 1 02/15/20, 07:40

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/setup/Classes/Controller/SetupModuleController.php
  2. TYPO3com voted on patch set 1 V -1 02/15/20, 07:42 Completed build in 29s on Sat, 15 Feb, 07:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-24

  3. Benni Mack commented on patch set 2 02/15/20, 07:42

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 02/15/20, 07:42

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 02/15/20, 07:55 Completed build in 13m 20s on Sat, 15 Feb, 07:55 AM Test Summary: 1 of 74927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-25

  6. TYPO3com voted on patch set 2 V +1 02/15/20, 08:09 Completed build in 39m 58s on Sat, 15 Feb, 08:09 AM Test Summary: 74327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-25

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/15/20, 09:20

  8. Benni Mack merged patch set 3 02/15/20, 09:20