Review TYPO3_8-7 Merged

63231[BUGFIX] Set correct PID for file references on new pages

Richard Haeser CR +2 V +2 Easy +34 −12 updated 02/17/20, 22:31

Commit message

Allow inline parent UID to have a "NEW..." placeholder value.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 810

  1. Richard Haeser commented on patch set 1 02/17/20, 21:39

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php * typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php
  2. TYPO3com voted on patch set 1 V -1 02/17/20, 21:44 Completed build in 34s on Mon, 17 Feb, 09:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-13

  3. Richard Haeser uploaded patch set 2 02/17/20, 22:08

  4. Richard Haeser commented on patch set 2 02/17/20, 22:08

    This change is ready for review.
  5. Richard Haeser voted on patch set 2 V +1 CR +1 02/17/20, 22:09

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/17/20, 22:28

  7. TYPO3com voted on patch set 2 V +1 02/17/20, 22:29 Completed build in 14m 53s on Mon, 17 Feb, 10:29 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-14

  8. Richard Haeser voted on patch set 2 V +2 CR +2 02/17/20, 22:30

  9. Richard Haeser merged patch set 3 02/17/20, 22:30

  10. Markus Klein commented on patch set 3 V +1 CR +1 02/17/20, 22:31

    tested as well, but merge was faster. thanks.