Review main Merged

63234[BUGFIX] Prevent PHP Warning for count() in scheduler for sqlite

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 02/29/20, 20:13

Commit message

As serialized_executions might be false instead of an array, check type
first. This ensures there will be no php warning

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Daniel Siepmann uploaded patch set 1 02/13/20, 11:46

  2. Daniel Siepmann updated the commit message in patch set 2 02/13/20, 11:47

  3. Mathias Brodala commented on patch set 2 02/13/20, 11:50

    Scheduler.php:130

    Wouldn't it make sense to move the whole block into the condition above? And possibly use an early "continue" for that one.
  4. Oliver Klee voted on patch set 2 CR +1 02/13/20, 11:57

  5. TYPO3com voted on patch set 1 V +1 02/13/20, 12:00 Completed build in 14m 08s on Thu, 13 Feb, 12:00 PM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-43

  6. TYPO3com voted on patch set 2 V +1 02/13/20, 12:07 Completed build in 16m 07s on Thu, 13 Feb, 12:07 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-44

  7. Susi Moog commented on patch set 2 CR +1 02/29/20, 19:30

    Scheduler.php:130 Reply Unresolved

    hm, I don't quite see how without changing the logic - the latter part should be executed even if serialized_executions is false.
  8. Susi Moog voted on patch set 2 V +1 02/29/20, 19:53

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 02/29/20, 20:13

  10. Daniel Goerz merged patch set 3 02/29/20, 20:13