Review main Merged

63236[TASK] Remove unused special GET parameters

Benni Mack CR +2 V +2 Easy +3 −8 updated 02/18/20, 14:46

Commit message

Several ADMCMD_ and  TSFE_ADMIN_PANEL variables
are excluded from cHash, but were never evaluated before.

The GET parameters are removed from setting and calculation
in cacheHash.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Benni Mack uploaded patch set 1 02/13/20, 15:49

  2. TYPO3com voted on patch set 1 V +1 02/13/20, 16:02 Completed build in 12m 49s on Thu, 13 Feb, 04:02 PM Test Summary: 71256 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-54

  3. Benni Mack updated the commit message in patch set 2 02/18/20, 09:23

  4. TYPO3com voted on patch set 2 V +1 02/18/20, 09:39 Completed build in 15m 03s on Tue, 18 Feb, 09:39 AM Test Summary: 71332 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-238

  5. Anja Leichsenring commented on patch set 2 02/18/20, 14:05

    PreviewController.php:153

    this doubles with line 160 now, without reading or writing the value. Are both needed?
  6. Benni Mack commented on patch set 2 02/18/20, 14:08

    PreviewController.php:153 Reply Unresolved

    yes. as it is again copied in 160 and other parameters are set. I'd keep it as is for now, had a look and tried it initially but felt it was possibly breaking something. (the first part sets "ADMCMD_noBeUser" and the second does not)
  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/18/20, 14:09

  8. Georg Ringer voted on patch set 2 V +2 CR +2 02/18/20, 14:46

  9. Georg Ringer merged patch set 3 02/18/20, 14:46