Review main Merged

63237[BUGFIX] Fix broken icon for groups with allowed all tables

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/14/20, 19:03

Commit message

This fixes the wrong comparison with the key instead of the value
in the foreach loop.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 02/13/20, 20:52

  2. TYPO3com voted on patch set 1 V +1 02/13/20, 21:22 Completed build in 25m 41s on Thu, 13 Feb, 09:22 PM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-56

  3. Oliver Klee voted on patch set 1 CR +1 02/13/20, 22:04

  4. Tymoteusz Motylewski voted on patch set 1 CR +1 02/14/20, 12:57

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 02/14/20, 13:39

  6. Georg Ringer voted on patch set 1 V +2 CR +2 02/14/20, 19:03

  7. Georg Ringer merged patch set 2 02/14/20, 19:03