Review main Merged

63245[BUGFIX] Show edit options only if editor got access

Georg Ringer CR +2 V +2 Normal +41 −13 updated 10/06/21, 09:39

Commit message

Check table select/modify options before rendering the action/button.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Sybille Peters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1317

  1. Georg Ringer uploaded patch set 1 02/14/20, 20:54

  2. Georg Ringer commented on patch set 1 02/14/20, 20:54

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 02/14/20, 22:03 Completed build in 35m 26s on Fri, 14 Feb, 10:03 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-94

  4. Stefan Froemken commented on patch set 1 V -1 02/14/20, 22:19

    If you go into list module, you can click the button to edit page-properties which will still result into the same problem. Same problem also in info module, if you edit page-properties over page-tree.
  5. Benni Mack commented on patch set 1 04/27/21, 20:27

    No activity in the past 14 months, anyone up for taking care of properly fixing this change?
  6. Markus Klein uploaded patch set 2 09/06/21, 09:25

  7. Markus Klein voted on patch set 2 CR +1 09/06/21, 09:26

  8. core-ci voted on patch set 2 V +1 09/06/21, 09:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16314

  9. Benni Mack voted on patch set 2 CR +1 09/27/21, 11:11

  10. Nikita Hovratov uploaded patch set 3 09/27/21, 15:44

  11. core-ci voted on patch set 3 V -1 09/27/21, 15:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17231

  12. Nikita Hovratov uploaded patch set 4 09/27/21, 16:23

  13. core-ci voted on patch set 4 V +1 09/27/21, 16:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17234

  14. Benni Mack voted on patch set 4 V +1 CR +1 09/27/21, 17:18

  15. Sybille Peters voted on patch set 4 V +1 10/02/21, 10:07

  16. Oli Bartsch voted on patch set 4 V +2 CR +2 10/06/21, 09:39

  17. Oli Bartsch merged patch set 5 10/06/21, 09:39