Review main Merged

63253[TASK] composer require phpstan/phpstan:"^0.12.10"

Alexander Schnitzler CR +2 V +2 Easy +14 −11 updated 02/17/20, 08:19

Commit message

Upgrade phpstan/phpstan to at least 0.12.10 and enable
bleeding edge configuration to be able to run the phpstan
analysis with all available cpu cores.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 12:13

  2. Alexander Schnitzler wrote 02/15/20, 12:29

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 02/15/20, 12:29 Completed build in 14m 52s on Sat, 15 Feb, 12:29 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-112

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 12:59

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 02/15/20, 13:54

  6. Andreas Kienast merged patch set 2 02/15/20, 13:54

  7. Mathias Brodala commented on patch set 2 02/17/20, 07:32

    phpstan.neon:2

    Post -1: we should not include the whole file but only copy the settings we need: > Of course, there are no backwards compatibility guarantees when you include this file. The behaviour and reported errors can change in minor versions with this file included. See https://github.com/phpstan/phpstan/releases/tag/0.12.10
  8. Alexander Schnitzler commented on patch set 2 02/17/20, 08:19

    phpstan.neon:2 Reply Unresolved

    Yes, true. I will create a patch which removes the include again.