63253[TASK] composer require phpstan/phpstan:"^0.12.10"
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 78
-
Alexander Schnitzler uploaded patch set 1 02/15/20, 12:13
-
Alexander Schnitzler wrote 02/15/20, 12:29
Topic set to phpstan -
TYPO3com voted on patch set 1 V +1 02/15/20, 12:29 Completed build in 14m 52s on Sat, 15 Feb, 12:29 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-112
-
Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 12:59
-
Andreas Kienast voted on patch set 1 V +2 CR +2 02/15/20, 13:54
-
Andreas Kienast merged patch set 2 02/15/20, 13:54
-
Mathias Brodala commented on patch set 2 02/17/20, 07:32
phpstan.neon:2Post -1: we should not include the whole file but only copy the settings we need: > Of course, there are no backwards compatibility guarantees when you include this file. The behaviour and reported errors can change in minor versions with this file included. See https://github.com/phpstan/phpstan/releases/tag/0.12.10 -
Alexander Schnitzler commented on patch set 2 02/17/20, 08:19
phpstan.neon:2Reply UnresolvedYes, true. I will create a patch which removes the include again.