Review main Merged

63254[BUGFIX] Client exceptions must return request

Alexander Schnitzler CR +2 V +2 Easy +2 −2 updated 02/15/20, 13:56

Commit message

Both the \TYPO3\CMS\Core\Http\Client\RequestException and
\TYPO3\CMS\Core\Http\Client\NetworkException declare a method
getRequest which must return a RequestInterface object which
they did not.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 12:37

  2. TYPO3com voted on patch set 1 V +1 02/15/20, 12:49 Completed build in 12m 49s on Sat, 15 Feb, 12:49 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-113

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 12:58

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 02/15/20, 13:56

  5. Daniel Goerz merged patch set 2 02/15/20, 13:56