63255[BUGFIX] Use multibyte method in CodeCompletionController
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- Andreas Kienast +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Georg Ringer uploaded patch set 1 02/15/20, 12:53
-
Georg Ringer commented on patch set 1 02/15/20, 12:54
This change is ready for review. -
Raphael Zschorsch commented on patch set 1 V +1 CR +1 02/15/20, 13:03
> Patch Set 1: > > This change is ready for review. -
TYPO3com voted on patch set 1 V +1 02/15/20, 13:06 Completed build in 12m 57s on Sat, 15 Feb, 01:06 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-114
-
Alexander Schnitzler commented on patch set 1 02/15/20, 13:22
CodeCompletionController.php:93UnresolvedShort notice: We should think about using symfony/string for things like this in the future. The lib has excellent support for any kind of string and comes with a nice object oriented way of dealing with strings. > (new UnicodeString($word))->length(); Of course not relevant for all strings in all places but extremely useful in case where we deal with non-ascii strings and perform things on the string like calculating it's length and so on. -
Andreas Kienast updated the commit message in patch set 2 02/15/20, 13:50
-
Andreas Kienast voted on patch set 2 CR +1 02/15/20, 13:50
-
Daniel Goerz commented on patch set 2 02/15/20, 13:55
How can I reproduce this? -
TYPO3com voted on patch set 2 V +1 02/15/20, 14:10 Completed build in 15m 07s on Sat, 15 Feb, 02:10 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-120
-
Daniel Goerz voted on patch set 2 CR +1 02/15/20, 14:15
-
Daniel Goerz voted on patch set 2 V +1 02/15/20, 16:54
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 02/16/20, 09:19
-
Tymoteusz Motylewski merged patch set 3 02/16/20, 09:20