Review main Merged

63260[TASK] composer require rector/rector:"~0.7" --dev

Alexander Schnitzler CR +2 V +2 Hard +648 −197 updated 02/15/20, 18:23

Commit message

Used commands:

    composer remove rector/rector --dev
    composer require rector/rector:"~0.7" --dev

Since updating phpstan to version 0.12.10, rector failed to
run properly. Also, the updated version of rector brings a
couple of bugfixes and new features.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 17:09

  2. TYPO3com voted on patch set 1 V -1 02/15/20, 17:22 Completed build in 12m 58s on Sat, 15 Feb, 05:22 PM Test Summary: 71007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-130

  3. TYPO3com voted on patch set 1 V +1 02/15/20, 17:53 Completed build in 57m 26s on Sat, 15 Feb, 05:53 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-130

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 18:13

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 02/15/20, 18:23

  6. Daniel Goerz merged patch set 2 02/15/20, 18:23