Review main Merged

63261[TASK] Do not use ::class syntax for class tx_crawler_lib

Alexander Schnitzler CR +2 V +2 Easy +5 −1 updated 02/15/20, 18:12

Commit message

This patch only pleases phpstan. The refactoring of the indexer
which includes the removal of the direct dependency to 3rd-party
classes is taken care of in the following issue.

https://forge.typo3.org/issues/83603

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 17:19

  2. TYPO3com voted on patch set 1 V +1 02/15/20, 17:32 Completed build in 12m 43s on Sat, 15 Feb, 05:32 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-131

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 02/15/20, 18:00

  4. Björn Jacob voted on patch set 1 V +1 CR +1 02/15/20, 18:08

  5. Georg Ringer voted on patch set 1 V +2 CR +2 02/15/20, 18:12

  6. Georg Ringer merged patch set 2 02/15/20, 18:12