Review main Merged

63262[TASK] Add missing methods in AbstractRenderable class

Alexander Schnitzler CR +2 V +2 Easy +10 −0 updated 02/16/20, 23:12

Commit message

This patch adds two methods setDefaultValue and setProperty
which are called from within class AbstractRenderable via
$this->setDefaultValue() and $this->setProperty() but are
meant to be called on a child class.

The implementation of said methods with an empty method body
only serve the purpose to please phpstan. As mentioned in
those method bodies, someone with a deeper understanding of
the form extension architecture needs to decide whether the
abstract class AbstractRenderable should only declare those
methods as abstract methods, i.e. child classes have to
implement them or if the abstract class can provide a
meaningful default behavior which can but doesn't need to
be overridden by child classes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Alexander Schnitzler uploaded patch set 1 02/15/20, 18:27

  2. Georg Ringer voted on patch set 1 V +1 CR +1 02/15/20, 18:29

  3. TYPO3com voted on patch set 1 V -1 02/15/20, 18:40 Completed build in 13m 20s on Sat, 15 Feb, 06:40 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-133

  4. TYPO3com voted on patch set 1 V +1 02/15/20, 18:56 Completed build in 41m 45s on Sat, 15 Feb, 06:56 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-133

  5. Benni Mack voted on patch set 1 V +2 CR +2 02/16/20, 23:12

  6. Benni Mack merged patch set 2 02/16/20, 23:12